Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Issue 2750303002: Show alert when failed to get token for opening suggested apps dialog. (Closed)

Created:
3 years, 9 months ago by fukino
Modified:
3 years, 9 months ago
Reviewers:
yamaguchi
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Show alert when failed to get token for opening suggested apps dialog. This will fix the regression where opening a ZIP file in the Guest mode gives no feedback. BUG=694419 TEST=Manually tested by opening a zip file in Guest mode. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=yamaguchi@chromium.org Review-Url: https://codereview.chromium.org/2740713002 Cr-Commit-Position: refs/heads/master@{#455631} (cherry picked from commit 8cc2674aa0a8f9da76f18fc55bd8adf4a4730a3b) Review-Url: https://codereview.chromium.org/2750303002 . Cr-Commit-Position: refs/branch-heads/3029@{#232} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/890c2e72e2c59b664f5b4f8eba2773d7252bfbbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 9 months ago (2017-03-16 08:06:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
890c2e72e2c59b664f5b4f8eba2773d7252bfbbe.

Powered by Google App Engine
This is Rietveld 408576698