Issue 2750293002: Ensure framework path is set before any web objects are created.

Issue 2750293002: Ensure framework path is set before any web objects are created. (Closed)

Created:
3 years, 9 months ago by michaeldo

Modified:
3 years, 9 months ago

Reviewers:
Eugene But (OOO till 7-30)

CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Ensure framework path is set before any web objects are created. BUG=none Review-Url: https://codereview.chromium.org/2750293002 Cr-Commit-Position: refs/heads/master@{#457457} Committed: https://chromium.googlesource.com/chromium/src/+/7bf3f1becca10d9c1fb493ff5d70fa5b9b2763c5

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	ios/web_view/internal/web_view_web_main_delegate.mm	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	ios/web_view/internal/web_view_web_main_parts.mm	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Dependent Patchsets:

Total messages: 8 (4 generated)

michaeldo

Note this fixes an issue where icu data isn't loaded early enough when running ios/web_view ...

3 years, 9 months ago (2017-03-16 05:36:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750293002/1

3 years, 9 months ago (2017-03-16 16:43:14 UTC) #5

commit-bot: I haz the power

3 years, 9 months ago (2017-03-16 16:53:09 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bf3f1becca10d9c1fb493ff5d70...