Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2750283002:
Makes //media public_deps of media_types.typemap. (Closed)
|
Created:
3 years, 9 months ago by alokp Modified:
3 years, 9 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review), Ken Rockot(use gerrit already) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMakes //media public_deps of media_types.typemap.
This provides the transitive dependency on skia which is required by
media/base/video_codecs.h.
BUG=702033
Review-Url: https://codereview.chromium.org/2750283002
Cr-Commit-Position: refs/heads/master@{#457503}
Committed: https://chromium.googlesource.com/chromium/src/+/58e4a73d8f76c0683d60cca2a487e88090b05fce
Patch Set 1 #Patch Set 2 : fixes typo #Messages
Total messages: 19 (11 generated)
The CQ bit was checked by alokp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alokp@chromium.org changed reviewers: + xhwang@chromium.org
Good catch. Thanks for the fix! LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alokp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
alokp@chromium.org changed reviewers: + tsepez@chromium.org
+tsepez: security review
OWNER RS LGTM stamp.
The CQ bit was checked by alokp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489687627906380,
"parent_rev": "815054b5918e1d631c4208b06b83d1e833ef6240", "commit_rev":
"58e4a73d8f76c0683d60cca2a487e88090b05fce"}
Message was sent while issue was closed.
Description was changed from ========== Makes //media public_deps of media_types.typemap. This provides the transitive dependency on skia which is required by media/base/video_codecs.h. BUG=702033 ========== to ========== Makes //media public_deps of media_types.typemap. This provides the transitive dependency on skia which is required by media/base/video_codecs.h. BUG=702033 Review-Url: https://codereview.chromium.org/2750283002 Cr-Commit-Position: refs/heads/master@{#457503} Committed: https://chromium.googlesource.com/chromium/src/+/58e4a73d8f76c0683d60cca2a487... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/58e4a73d8f76c0683d60cca2a487... |
