Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

Issue 2750273003: In wpt-update-expectations, ignore tests that unexpectedly pass. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
index 847eb2fa1aad1b82b82f5295a0159ce1a6c9b267..f40df9e19a635879a069ac02fe0cbceb74a96f73 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
@@ -69,6 +69,22 @@ class WPTExpectationsUpdaterTest(LoggingTestCase):
updater = WPTExpectationsUpdater(host)
self.assertEqual(updater.get_failing_results_dict(Build('MOCK Try Mac10.10', 123)), {})
+ def test_get_failing_results_dict_unexpected_pass(self):
+ host = self.mock_host()
+ host.buildbot.set_results(Build('MOCK Try Mac10.10', 123), LayoutTestResults({
+ 'tests': {
+ 'x': {
+ 'passing-test.html': {
+ 'expected': 'FAIL TIMEOUT',
+ 'actual': 'PASS',
+ 'is_unexpected': True,
+ },
+ },
+ },
+ }))
+ updater = WPTExpectationsUpdater(host)
+ self.assertEqual(updater.get_failing_results_dict(Build('MOCK Try Mac10.10', 123)), {})
+
def test_get_failing_results_dict_no_results(self):
host = self.mock_host()
host.buildbot = MockBuildBot()
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698