DescriptionRevert of Mojo EDK: Introduce MojoQueryHandleSignalsState API (patchset #9 id:160001 of https://codereview.chromium.org/2741033003/ )
Reason for revert:
This CL seems to break mojo_system_unittests on multiple bots:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/53232
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/64801
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/9606
Here are samples of the failing tests. Most of them are failed by time out:
MessagePipeTest.DiscardMode
WatcherTest.WatchDataPipeConsumerReadable
WatcherTest.WatchMessagePipeReadable
MessagePipeTest.Basic
DataPipeTest.PeerClosedProducerWaiting
Original issue's description:
> Mojo EDK: Introduce MojoQueryHandleSignalsState API
>
> The only reliable way to inquire about handle signals now
> is to MojoWait (for e.g. 0 deadline). As a precursor to
> removing the wait APIs in favor of watchers, we need to
> retain the ability to efficiently query a handle's signals
> state.
>
> Rather than trying to retrofit the watcher APIs to support
> this use case in similar fashion to the wait APIs, this adds
> an API explicitly for the purpose of querying signals state.
>
> Adds a corresponding method to the C++ mojo::Handle
> and moves the EDK's internal HandleSignalsState helper class
> to mojo/public/cpp/system, adding some convenient accessors.
>
> Also introduces the API to the JS and Java libraries, and
> replaces any 0-deadline waits in those languages with usage of
> this new API.
>
> Because waitMany is not used in these languages (except for
> tests which test waitMany...) it has been removed. wait() is
> unused in Java after this change, so it has also been removed.
>
> Finally, this moves several tests away from calling MojoWait
> directly, instead using a simplified Watcher-based wait
> implementation in MojoTestBase.
>
> BUG=700171
> TBR=jam@chromium.org
>
> Review-Url: https://codereview.chromium.org/2741033003
> Cr-Commit-Position: refs/heads/master@{#457315}
> Committed: https://chromium.googlesource.com/chromium/src/+/853496a78ae997c2d8b80f3cd8fabf9423fb3361
TBR=yzshen@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=700171
Review-Url: https://codereview.chromium.org/2750273002
Cr-Commit-Position: refs/heads/master@{#457342}
Committed: https://chromium.googlesource.com/chromium/src/+/e3ca1cc824f2fb89cb0bc219844f13f09afdcbd7
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|