Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2750273002: Revert of Mojo EDK: Introduce MojoQueryHandleSignalsState API (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo EDK: Introduce MojoQueryHandleSignalsState API (patchset #9 id:160001 of https://codereview.chromium.org/2741033003/ ) Reason for revert: This CL seems to break mojo_system_unittests on multiple bots: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/53232 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/64801 https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/9606 Here are samples of the failing tests. Most of them are failed by time out: MessagePipeTest.DiscardMode WatcherTest.WatchDataPipeConsumerReadable WatcherTest.WatchMessagePipeReadable MessagePipeTest.Basic DataPipeTest.PeerClosedProducerWaiting Original issue's description: > Mojo EDK: Introduce MojoQueryHandleSignalsState API > > The only reliable way to inquire about handle signals now > is to MojoWait (for e.g. 0 deadline). As a precursor to > removing the wait APIs in favor of watchers, we need to > retain the ability to efficiently query a handle's signals > state. > > Rather than trying to retrofit the watcher APIs to support > this use case in similar fashion to the wait APIs, this adds > an API explicitly for the purpose of querying signals state. > > Adds a corresponding method to the C++ mojo::Handle > and moves the EDK's internal HandleSignalsState helper class > to mojo/public/cpp/system, adding some convenient accessors. > > Also introduces the API to the JS and Java libraries, and > replaces any 0-deadline waits in those languages with usage of > this new API. > > Because waitMany is not used in these languages (except for > tests which test waitMany...) it has been removed. wait() is > unused in Java after this change, so it has also been removed. > > Finally, this moves several tests away from calling MojoWait > directly, instead using a simplified Watcher-based wait > implementation in MojoTestBase. > > BUG=700171 > TBR=jam@chromium.org > > Review-Url: https://codereview.chromium.org/2741033003 > Cr-Commit-Position: refs/heads/master@{#457315} > Committed: https://chromium.googlesource.com/chromium/src/+/853496a78ae997c2d8b80f3cd8fabf9423fb3361 TBR=yzshen@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700171 Review-Url: https://codereview.chromium.org/2750273002 Cr-Commit-Position: refs/heads/master@{#457342} Committed: https://chromium.googlesource.com/chromium/src/+/e3ca1cc824f2fb89cb0bc219844f13f09afdcbd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+793 lines, -639 lines) Patch
M content/child/web_data_consumer_handle_impl.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/HandleMock.java View 2 chunks +9 lines, -6 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/RouterTest.java View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java View 6 chunks +124 lines, -2 lines 0 comments Download
M mojo/android/system/core_impl.cc View 2 chunks +49 lines, -9 lines 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java View 6 chunks +59 lines, -10 lines 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/HandleBase.java View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/edk/embedder/entrypoints.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/edk/js/core.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/awakable_list.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/awakable_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/core.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/edk/system/core.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M mojo/edk/system/data_pipe_unittest.cc View 51 chunks +147 lines, -80 lines 0 comments Download
M mojo/edk/system/handle_signals_state.h View 1 chunk +39 lines, -3 lines 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 18 chunks +58 lines, -35 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 25 chunks +56 lines, -28 lines 0 comments Download
D mojo/edk/system/signals_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M mojo/edk/test/mojo_test_base.h View 2 chunks +2 lines, -8 lines 0 comments Download
M mojo/edk/test/mojo_test_base.cc View 8 chunks +13 lines, -120 lines 0 comments Download
M mojo/public/c/system/functions.h View 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 6 chunks +23 lines, -11 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest_pure_c.c View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/c/system/thunks.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/c/system/thunks.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/public/cpp/system/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/system/handle.h View 2 chunks +0 lines, -9 lines 0 comments Download
D mojo/public/cpp/system/handle_signals_state.h View 1 chunk +0 lines, -83 lines 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/cpp/system/tests/handle_signals_state_unittest.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/Core.java View 2 chunks +138 lines, -0 lines 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/Handle.java View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/InvalidHandle.java View 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/public/js/core.js View 1 chunk +0 lines, -12 lines 0 comments Download
M mojo/public/js/tests/core_unittest.js View 2 chunks +37 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tzik
Created Revert of Mojo EDK: Introduce MojoQueryHandleSignalsState API
3 years, 9 months ago (2017-03-16 03:57:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750273002/1
3 years, 9 months ago (2017-03-16 03:57:41 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 04:00:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3ca1cc824f2fb89cb0bc219844f...

Powered by Google App Engine
This is Rietveld 408576698