Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2750263002: Remove ash tray utility functions that are no-ops in MD. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ash tray utility functions that are no-ops in MD. BUG=686282 Review-Url: https://codereview.chromium.org/2750263002 Cr-Commit-Position: refs/heads/master@{#457507} Committed: https://chromium.googlesource.com/chromium/src/+/0c0062ad76b65062642e37c0df51080ce53fe839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -129 lines) Patch
M ash/common/system/chromeos/network/tray_network.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/network/tray_network.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/common/system/chromeos/power/tray_power.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/power/tray_power.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/common/system/tray/tray_image_item.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ash/common/system/tray/tray_image_item.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M ash/common/system/tray/tray_utils.h View 1 chunk +0 lines, -16 lines 0 comments Download
M ash/common/system/tray/tray_utils.cc View 1 chunk +5 lines, -59 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 9 months ago (2017-03-16 01:12:16 UTC) #2
tdanderson
LGTM
3 years, 9 months ago (2017-03-16 18:11:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750263002/1
3 years, 9 months ago (2017-03-16 18:48:20 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 18:56:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c0062ad76b65062642e37c0df51...

Powered by Google App Engine
This is Rietveld 408576698