Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2750173007: [png_asset_size] optimize pngs in java/res, part 1/3: mdpi and hdpi. (Closed)

Created:
3 years, 9 months ago by vitaliii
Modified:
3 years, 9 months ago
Reviewers:
Theresa
CC:
chromium-reviews, subresource-filter-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[png_asset_size] optimize pngs in java/res, part 1/3: mdpi and hdpi. I ran optimize-png-files.sh -o2 on chrome/android/java/res/. This is result for mdpi and hdpi subfolders. The small (~10 bytes) optimizations were ignored. Overall: 3386 bytes saved, originally 37814 bytes -> 8.9%. Results log: drawable-hdpi/add_circle_blue.png: 1395 => 522 (873 bytes: 62%) drawable-hdpi/btn_tab_close.png: 217 => 133 (84 bytes: 38%) drawable-hdpi/google_logo.png: 6126 => 6053 (73 bytes: 1%) drawable-hdpi/ic_content_copy.png: 275 => 225 (50 bytes: 18%) drawable-hdpi/ic_get_app_white_24dp.png: 260 => 147 (113 bytes: 43%) drawable-hdpi/infobar_subresource_filtering.png: 585 => 300 (285 bytes: 48%) drawable-hdpi/ntp_signin_promo_card_single.9.png: 462 => 253 (209 bytes: 45%) drawable-hdpi/search_sogou.png: 15545 => 15484 (61 bytes: 0%) drawable-hdpi/settings_usb.png: 769 => 348 (421 bytes: 54%) drawable-mdpi/add_circle_blue.png: 836 => 358 (478 bytes: 57%) drawable-mdpi/btn_tab_close.png: 165 => 103 (62 bytes: 37%) drawable-mdpi/ic_content_copy.png: 170 => 149 (21 bytes: 12%) drawable-mdpi/ic_get_app_white_24dp.png: 193 => 113 (80 bytes: 41%) drawable-mdpi/infobar_subresource_filtering.png: 499 => 272 (227 bytes: 45%) drawable-mdpi/ntp_signin_promo_card_single.9.png: 291 => 171 (120 bytes: 41%) drawable-mdpi/search_sogou.png: 9607 => 9583 (24 bytes: 0%) drawable-mdpi/settings_usb.png: 419 => 214 (205 bytes: 48%) BUG=702553 Review-Url: https://codereview.chromium.org/2750173007 Cr-Commit-Position: refs/heads/master@{#458767} Committed: https://chromium.googlesource.com/chromium/src/+/ccce774978e841a8ff6374df0a7366627a3393ac

Patch Set 1 #

Patch Set 2 : clean rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/android/java/res/drawable-hdpi/add_circle_blue.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/btn_tab_close.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/google_logo.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/ic_content_copy.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/ic_file_download_white_24dp.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_subresource_filtering.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/ntp_signin_promo_card_single.9.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/search_sogou.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/settings_usb.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/add_circle_blue.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/btn_tab_close.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/ic_content_copy.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/ic_file_download_white_24dp.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_subresource_filtering.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/ntp_signin_promo_card_single.9.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/search_sogou.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/settings_usb.png View Binary file 0 comments Download

Messages

Total messages: 18 (12 generated)
vitaliii
Hi twellington@, Could you have a look please?
3 years, 9 months ago (2017-03-17 10:29:58 UTC) #4
Theresa
Thank you for running these! I looked through the files and they all look good ...
3 years, 9 months ago (2017-03-17 15:26:30 UTC) #7
vitaliii
Hi twellington@, Could you have a look as an OWNER? I rebased and now the ...
3 years, 9 months ago (2017-03-22 13:52:06 UTC) #12
Theresa
lgtm
3 years, 9 months ago (2017-03-22 16:11:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750173007/20001
3 years, 9 months ago (2017-03-22 16:17:13 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 16:22:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ccce774978e841a8ff6374df0a73...

Powered by Google App Engine
This is Rietveld 408576698