Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/renderer/media/media_stream_constraints_util_video_content.h

Issue 2750163002: Use spec-compliant algorithm for video content-capture deviceId selection in getUserMedia. (Closed)
Patch Set: address review comments and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/media_stream_constraints_util_video_content.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_constraints_util_video_content.h
diff --git a/content/renderer/media/media_stream_constraints_util_video_content.h b/content/renderer/media/media_stream_constraints_util_video_content.h
index 250b4ecd03729a75fc582d524113459dabd4594e..f68a41d5817f3d963a4ab246fe2a6e8bd55962e6 100644
--- a/content/renderer/media/media_stream_constraints_util_video_content.h
+++ b/content/renderer/media/media_stream_constraints_util_video_content.h
@@ -20,14 +20,16 @@ namespace content {
class CONTENT_EXPORT VideoContentCaptureSourceSelectionResult {
public:
+ // Creates a result without value and with an empty failed constraint name.
+ VideoContentCaptureSourceSelectionResult();
+
// Creates a result without value and with the given |failed_constraint_name|.
// Does not take ownership of |failed_constraint_name|, so it must be null or
// point to a string that remains accessible.
explicit VideoContentCaptureSourceSelectionResult(
const char* failed_constraint_name);
- // Creates a result with the given values. |device_id| is moved to an internal
- // field.
+ // Creates a result with the given values.
VideoContentCaptureSourceSelectionResult(
std::string device_id,
const rtc::Optional<bool>& noise_reduction,
« no previous file with comments | « no previous file | content/renderer/media/media_stream_constraints_util_video_content.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698