content/renderer/media/media_stream_constraints_util_video_content.cc - Issue 2750163002: Use spec-compliant algorithm for video content-capture deviceId selection in getUserMedia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_constraints_util_video_content.cc

Issue 2750163002: Use spec-compliant algorithm for video content-capture deviceId selection in getUserMedia. (Closed)

Patch Set: address review comments and rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_constraints_util_video_content.h ('k') | content/renderer/media/user_media_client_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_constraints_util_video_content.cc

diff --git a/content/renderer/media/media_stream_constraints_util_video_content.cc b/content/renderer/media/media_stream_constraints_util_video_content.cc

index e13c2439c3a497d45d988f851d942fcadf11b663..0376be5c5c27da77d784bc863e6d9c1bedd9d08c 100644

--- a/content/renderer/media/media_stream_constraints_util_video_content.cc

+++ b/content/renderer/media/media_stream_constraints_util_video_content.cc

@@ -252,6 +252,10 @@ VideoContentCaptureSourceSelectionResult UnsatisfiedConstraintsResult(

} // namespace

VideoContentCaptureSourceSelectionResult::

+ VideoContentCaptureSourceSelectionResult()

+ : VideoContentCaptureSourceSelectionResult("") {}

+VideoContentCaptureSourceSelectionResult::

VideoContentCaptureSourceSelectionResult(const char* failed_constraint_name)

: failed_constraint_name_(failed_constraint_name) {}