Chromium Code Reviews Chromium Code Reviews
Issue 2750153002:
getClientRects() shouldn't clip against any ancestors. (Closed)
| Index: third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html b/third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..771144e02c6d5c19dd256a2e79cecc074be461b1 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html |
| @@ -0,0 +1,19 @@ |
| +<!DOCTYPE html> |
| +<style>body { margin:8px; }</style> |
| +<div style="columns:1; width:10px; height:200px; column-fill:auto;"> |
| + <div id="elm" style="margin-left:-20px; margin-top:-25px; width:4000px; height:40px;"></div> |
| +</div> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<script> |
| + test(() => { |
| + var elm = document.getElementById("elm"); |
| + var rects = elm.getClientRects(); |
| + assert_equals(rects.length, 1); |
| + var rect = rects[0]; |
| + assert_equals(rect.left, -12); |
| + assert_equals(rect.top, -17); |
| + assert_equals(rect.right, 3988); |
|
eae
2017/03/18 20:23:25
A comment explaining the values would be helpful.
mstensho (USE GERRIT)
2017/03/20 09:38:22
Done.
Also switched to using width/height instead
|
| + assert_equals(rect.bottom, 23); |
| + }, "getClientRects should include overflow"); |
| +</script> |
