Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2750133003: Revert of DevTools: move flow events tracking to TracingModel, support cross-threads case (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
caseq, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: move flow events tracking to TracingModel, support cross-threads case (patchset #2 id:20001 of https://codereview.chromium.org/2746153005/ ) Reason for revert: Breaks flow events completely. Original issue's description: > DevTools: move flow events tracking to TracingModel, support cross-threads case > > This implements support for tracking flow events in TracingModel and correctly supports the spec in terms of id matching for flow events. > > Review-Url: https://codereview.chromium.org/2746153005 > Cr-Commit-Position: refs/heads/master@{#457245} > Committed: https://chromium.googlesource.com/chromium/src/+/56024c61ffdabb977c7645098cb4654c6a1fdcc1 TBR=alph@chromium.org,caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2750133003 Cr-Commit-Position: refs/heads/master@{#457295} Committed: https://chromium.googlesource.com/chromium/src/+/8fdeee30d2eaf99de96e21785b564884f91000cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -172 lines) Patch
D third_party/WebKit/LayoutTests/inspector/tracing-model-flow.html View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/tracing-model-flow-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js View 7 chunks +1 line, -51 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 7 chunks +49 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pfeldman
Created Revert of DevTools: move flow events tracking to TracingModel, support cross-threads case
3 years, 9 months ago (2017-03-16 01:13:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750133003/1
3 years, 9 months ago (2017-03-16 01:14:26 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 01:15:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8fdeee30d2eaf99de96e21785b56...

Powered by Google App Engine
This is Rietveld 408576698