Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2750123002: android: AtomicReference over ModerateBindingPoolLock (Closed)

Created:
3 years, 9 months ago by boliu
Modified:
3 years, 9 months ago
Reviewers:
Maria
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: AtomicReference over ModerateBindingPoolLock Does the exact same thing, but imo more readable. BUG=689758 Review-Url: https://codereview.chromium.org/2750123002 Cr-Commit-Position: refs/heads/master@{#457364} Committed: https://chromium.googlesource.com/chromium/src/+/c3458a35d1cbf723a6ddc4a75cce9148eeafed82

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java View 1 8 chunks +13 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
boliu
ptal
3 years, 9 months ago (2017-03-15 19:07:32 UTC) #2
Maria
lgtm
3 years, 9 months ago (2017-03-16 05:05:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750123002/20001
3 years, 9 months ago (2017-03-16 05:25:36 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 06:21:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3458a35d1cbf723a6ddc4a75cce...

Powered by Google App Engine
This is Rietveld 408576698