Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/browser/ui/views/harmony/layout_delegate.h

Issue 2750063002: views: implement dialog width snapping (Closed)
Patch Set: width -> min_width and improve tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/layout_delegate.h
diff --git a/chrome/browser/ui/views/harmony/layout_delegate.h b/chrome/browser/ui/views/harmony/layout_delegate.h
index f0ad07d93382a5f6949ef620eea9680b23ddf526..d17971218c972baf03aa16a8d33bb7c755e9b45e 100644
--- a/chrome/browser/ui/views/harmony/layout_delegate.h
+++ b/chrome/browser/ui/views/harmony/layout_delegate.h
@@ -107,9 +107,9 @@ class LayoutDelegate {
// TODO(pkasting): Fix callers and remove this.
virtual bool IsHarmonyMode() const;
- // Returns the preferred width in DIPs for a dialog of the specified |width|.
- // May return 0 if the dialog has no preferred width.
- virtual int GetDialogPreferredWidth(DialogWidth width) const;
+ // Returns the preferred width in DIPs for a dialog of the specified
+ // |min_width|. May return 0 if the dialog has no preferred width.
Peter Kasting 2017/04/06 06:32:16 Nit: Comment seems outdated. Maybe "Returns the a
+ virtual int GetSnappedDialogWidth(int min_width) const;
// Returns the class that maps views::style values (TextContext and TextStyle)
// to specific font properties (e.g. typeface, size, color, line spacing).

Powered by Google App Engine
This is Rietveld 408576698