Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5324)

Unified Diff: chrome/browser/ui/views/harmony/harmony_layout_delegate.cc

Issue 2750063002: views: implement dialog width snapping (Closed)
Patch Set: width -> min_width and improve tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
diff --git a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
index 8afd20369d3b97654914b2ba6851b72ac51e2eea..fe65ee36b8d1d88e56598e50d482039bb8926cb0 100644
--- a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
+++ b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
@@ -84,15 +84,11 @@ bool HarmonyLayoutDelegate::IsHarmonyMode() const {
return true;
}
-int HarmonyLayoutDelegate::GetDialogPreferredWidth(DialogWidth width) const {
- switch (width) {
- case DialogWidth::SMALL:
- return 320;
- case DialogWidth::MEDIUM:
- return 448;
- case DialogWidth::LARGE:
- return 512;
+int HarmonyLayoutDelegate::GetSnappedDialogWidth(int min_width) const {
+ for (int width : {320, 448, 512}) {
+ if (min_width <= width)
+ return width;
}
- NOTREACHED();
- return 0;
+ return ((min_width + kHarmonyLayoutUnit - 1) / kHarmonyLayoutUnit) *
+ kHarmonyLayoutUnit;
}

Powered by Google App Engine
This is Rietveld 408576698