bindings: Correctly expand all class/header dependencies in unions.

bindings: Correctly expand all class/header dependencies in unions.

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2750003003
Cr-Commit-Position: refs/heads/master@{#457381}
Committed: https://chromium.googlesource.com/chromium/src/+/8552274ebe052e07472a852e37f6cbbe73bbecda

[Raphael Kubo da Costa (rakuco), 2017-03-15 18:45:52]

Description was changed from

==========
bindings: Correctly expand all class/header dependencies in unions.

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This was affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Correctly expand all class/header dependencies in unions.

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This was affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

[Raphael Kubo da Costa (rakuco), 2017-03-15 18:46:01]

PTAL.

[Raphael Kubo da Costa (rakuco), 2017-03-15 18:46:08]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 18:46:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-15 20:05:42]

LGTM although bashi@ might want to take a look.

Your CL description is always awesome :)

[commit-bot: I haz the power, 2017-03-15 20:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:18:37]

Dry run: This issue passed the CQ dry run.

[Raphael Kubo da Costa (rakuco), 2017-03-15 20:59:11]

Description was changed from

==========
bindings: Correctly expand all class/header dependencies in unions.

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This was affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Correctly expand all class/header dependencies in unions.

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

[bashi, 2017-03-15 23:39:58]

lgtm.

On 2017/03/15 20:05:42, haraken wrote:
> LGTM although bashi@ might want to take a look.
> 
> Your CL description is always awesome :)

Totally agreed. Thank you for writing awesome descriptions.

[Raphael Kubo da Costa (rakuco), 2017-03-16 08:59:23]

Thanks, I try to make the commit messages very descriptive for my own sake, so
that I can go back to this code in 2 or 3 years and still understand what I was
doing :-)

[Raphael Kubo da Costa (rakuco), 2017-03-16 08:59:40]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-03-16 09:00:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 09:08:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489654780980720, "parent_rev":
"5fd99fadaac4fa9d7b18593ef00d4ca20a3cdcf0", "commit_rev":
"8552274ebe052e07472a852e37f6cbbe73bbecda"}

[commit-bot: I haz the power, 2017-03-16 09:09:38]

Description was changed from

==========
bindings: Correctly expand all class/header dependencies in unions.

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Correctly expand all class/header dependencies in unions.

Prior to this CL, an IDL construct like this:

    void func((boolean or sequence<Element>) arg);

would generate two union files, BooleanOrElementSequence.cpp and
BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations
such as:

    const HeapVector<Member<Element>>& getAsElementSequence() const;
    HeapVector<Member<Element>> m_elementSequence;

However, it does not forward-declare Element, nor does it include
Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes
V8Element.h, leading to build failures.

This affected any types inside unions that require forward declarations
and additional headers to be included which were inside a container type,
such as a record or a sequence. For instance, the constructs below were all
problematic:
* (boolean or sequence<Element>)
* (float or sequence<(boolean or long)>)
* (double or record<ByteString, Element>)

Solve this by expanding v8_union._update_includes_and_forward_decls() and
making it more similar to code_generator_v8's depending_union_type() and
TypedefResolver:
* If we're parsing a container type (ie. a record or a sequence), we call
  the function recursively to make sure all headers/forward declarations are
  taken care of.
* If we're parsing a union type, the union was inside a container type (as
  otherwise it would have been broken up by us looping through flattened
  union members), in which case we forward-declare the union and include its
  header in the outer union's .cpp file.

BUG=701410
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2750003003
Cr-Commit-Position: refs/heads/master@{#457381}
Committed:
https://chromium.googlesource.com/chromium/src/+/8552274ebe052e07472a852e37f6...
==========

[commit-bot: I haz the power, 2017-03-16 09:09:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8552274ebe052e07472a852e37f6...

[Yuki, 2017-03-16 13:25:36]

LGTM.