Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2750003002: Fixed broken type names in memory-infra tracing. (Closed)

Created:
3 years, 9 months ago by tasak
Modified:
3 years, 9 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed broken type names reported by blink_gc. When running Android chrome with heap profiling, some type names are broken. Because the type names are allocated on stack. BUG= Review-Url: https://codereview.chromium.org/2750003002 Cr-Commit-Position: refs/heads/master@{#457044} Committed: https://chromium.googlesource.com/chromium/src/+/d9945242d106d9aae4765d236f4b6195a3292ae6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
tasak
PTAL?
3 years, 9 months ago (2017-03-15 06:38:40 UTC) #5
sof
lgtm
3 years, 9 months ago (2017-03-15 06:40:41 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-15 07:36:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750003002/1
3 years, 9 months ago (2017-03-15 09:48:08 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 09:53:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9945242d106d9aae4765d236f4b...

Powered by Google App Engine
This is Rietveld 408576698