compositor: Change how attributes are set during ui::Layer::Clone().

compositor: Change how attributes are set during ui::Layer::Clone().

A solid-color layer with SK_ColorTRANSPARENT color can be marked as
opaque, as is done in ash-mus to reduce overdraw (crrev.com/456910). When
Clone()ing the Layer, the opaque-ness of the layer is cloned first, and
then the color is set. However, ui::Layer can turn off the opaque-ness
when setting the color, if color is transparent. So, set up color etc.
of a ui::Layer first when cloning, before setting remaining properties.

Without this fix, anytime a window is maximized/restored (which uses
cloned layers), ash loses the overdraw optimization.

BUG=701653
Review-Url: https://codereview.chromium.org/2749993002
Cr-Commit-Position: refs/heads/master@{#457126}
Committed: https://chromium.googlesource.com/chromium/src/+/458e50ea1e561feeb779ff7a26310e59b43fc0d6

[sadrul, 2017-03-15 02:53:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 02:54:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 04:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 04:11:14]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-15 04:31:00]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 04:31:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-15 04:38:54]

Description was changed from

==========
[exp] compositor: Change how attributes are set during Clone().

...

BUG=...
==========

to

==========
compositor: Change how attributes are set during ui::Layer::Clone().

A solid-color layer with SK_ColorTRANSPARENT color can be marked as
opaque, as is done in ash-mus to reduce overdraw (crrev.com/456910). When
Clone()ing the Layer, the opaque-ness of the layer is cloned first, and
then the color is set. However, ui::Layer can turn off the opaque-ness
when setting the color, if color is transparent. So, set up color etc.
of a ui::Layer first when cloning, before setting remaining properties.

Without this fix, anytime a window is maximized/restored (which uses
cloned layers), ash loses the overdraw optimization.

BUG=701653
==========

[sadrul, 2017-03-15 04:39:44]

sadrul@chromium.org changed reviewers:
+ danakj@chromium.org

[commit-bot: I haz the power, 2017-03-15 05:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 05:49:59]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-03-15 15:23:41]

LGTM

[sadrul, 2017-03-15 17:29:45]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:30:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 17:44:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489598985831290,
"parent_rev": "f7a4edf6ff0a6e3e7cb3e7462b83029c749ef461", "commit_rev":
"458e50ea1e561feeb779ff7a26310e59b43fc0d6"}

[commit-bot: I haz the power, 2017-03-15 17:45:19]

Description was changed from

==========
compositor: Change how attributes are set during ui::Layer::Clone().

A solid-color layer with SK_ColorTRANSPARENT color can be marked as
opaque, as is done in ash-mus to reduce overdraw (crrev.com/456910). When
Clone()ing the Layer, the opaque-ness of the layer is cloned first, and
then the color is set. However, ui::Layer can turn off the opaque-ness
when setting the color, if color is transparent. So, set up color etc.
of a ui::Layer first when cloning, before setting remaining properties.

Without this fix, anytime a window is maximized/restored (which uses
cloned layers), ash loses the overdraw optimization.

BUG=701653
==========

to

==========
compositor: Change how attributes are set during ui::Layer::Clone().

A solid-color layer with SK_ColorTRANSPARENT color can be marked as
opaque, as is done in ash-mus to reduce overdraw (crrev.com/456910). When
Clone()ing the Layer, the opaque-ness of the layer is cloned first, and
then the color is set. However, ui::Layer can turn off the opaque-ness
when setting the color, if color is transparent. So, set up color etc.
of a ui::Layer first when cloning, before setting remaining properties.

Without this fix, anytime a window is maximized/restored (which uses
cloned layers), ash loses the overdraw optimization.

BUG=701653

Review-Url: https://codereview.chromium.org/2749993002
Cr-Commit-Position: refs/heads/master@{#457126}
Committed:
https://chromium.googlesource.com/chromium/src/+/458e50ea1e561feeb779ff7a2631...
==========

[commit-bot: I haz the power, 2017-03-15 17:45:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/458e50ea1e561feeb779ff7a2631...