Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2749983002: use namespace base for base::make_optional in docs (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use namespace base for base::make_optional in docs BUG=none TBR=mlamouri@chromium.org Review-Url: https://codereview.chromium.org/2749983002 Cr-Commit-Position: refs/heads/master@{#456964} Committed: https://chromium.googlesource.com/chromium/src/+/4a9c82efe768ec239706ef632b95c1c6b22ab72d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M docs/optional.md View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
michaelpg
3 years, 9 months ago (2017-03-15 02:30:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749983002/1
3 years, 9 months ago (2017-03-15 02:31:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4a9c82efe768ec239706ef632b95c1c6b22ab72d
3 years, 9 months ago (2017-03-15 02:45:22 UTC) #7
mlamouri (slow - plz ping)
3 years, 9 months ago (2017-03-15 09:57:32 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698