Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 2749953003: WATCHLISTS: Include test directories for workers (Closed)

Created:
3 years, 2 months ago by falken
Modified:
3 years, 2 months ago
Reviewers:
nhiroki
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WATCHLISTS: Include test directories for workers Review-Url: https://codereview.chromium.org/2749953003 Cr-Commit-Position: refs/heads/master@{#457020} Committed: https://chromium.googlesource.com/chromium/src/+/fc599795d2c67209375dddfe4806d9b58a5f1905

Patch Set 1 #

Patch Set 2 : ok #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M WATCHLISTS View 1 2 chunks +8 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
falken
ptal
3 years, 2 months ago (2017-03-15 06:22:13 UTC) #2
nhiroki
LGTM https://codereview.chromium.org/2749953003/diff/20001/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2749953003/diff/20001/WATCHLISTS#newcode1447 WATCHLISTS:1447: 'blink_serviceworkers_tests' : { Is this still necessary? (kenjibaheux@ ...
3 years, 2 months ago (2017-03-15 06:33:13 UTC) #3
falken
On 2017/03/15 06:33:13, nhiroki (slow) wrote: > LGTM > > https://codereview.chromium.org/2749953003/diff/20001/WATCHLISTS > File WATCHLISTS (right): ...
3 years, 2 months ago (2017-03-15 06:42:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749953003/20001
3 years, 2 months ago (2017-03-15 06:43:03 UTC) #6
commit-bot: I haz the power
3 years, 2 months ago (2017-03-15 07:10:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc599795d2c67209375dddfe4806...

Powered by Google App Engine
This is Rietveld 408576698