Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4932)

Unified Diff: cc/tiles/image_controller_unittest.cc

Issue 2749933002: cc: Fix a flake in ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/image_controller_unittest.cc
diff --git a/cc/tiles/image_controller_unittest.cc b/cc/tiles/image_controller_unittest.cc
index 90b708f30471c8ad34f886d3e0f2e1cec0028686..06c7e996a9cb9bef211e93c68122902e1016fa69 100644
--- a/cc/tiles/image_controller_unittest.cc
+++ b/cc/tiles/image_controller_unittest.cc
@@ -190,7 +190,6 @@ class BlockingTask : public TileTask {
void RunOnWorkerThread() override {
EXPECT_FALSE(HasCompleted());
- EXPECT_FALSE(thread_checker_.CalledOnValidThread());
danakj 2017/03/14 21:10:11 You could #if DCHECK_IS_ON() or smoething if u wan
danakj 2017/03/14 21:10:46 You can also use ThreadCheckerImpl if you want
vmpstr 2017/03/15 17:41:57 Good idea. I did ThreadCheckerImpl instead.
base::AutoLock hold(lock_);
if (!can_run_)
run_cv_.Wait();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698