Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2749893003: Add More action to Content Suggestions (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add More action to Content Suggestions This CL adds a More action to the footer of Content Suggestions sections, allowing the user to interact further with the suggestions. BUG=700296 Review-Url: https://codereview.chromium.org/2749893003 Cr-Commit-Position: refs/heads/master@{#457147} Committed: https://chromium.googlesource.com/chromium/src/+/3033d50afdfff2e005c5fe14c9c588765610e6e9

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 5 chunks +57 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-15 17:10:48 UTC) #2
lpromero
lgtm
3 years, 9 months ago (2017-03-15 18:08:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749893003/20001
3 years, 9 months ago (2017-03-15 18:09:17 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:26:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3033d50afdfff2e005c5fe14c9c5...

Powered by Google App Engine
This is Rietveld 408576698