Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2749863003: [Merge M57] Reverting 2618623003. (Closed)

Created:
3 years, 9 months ago by Georges Khalil
Modified:
3 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Reverting 2618623003. Call to IsOS will fail if \Device\NamedPipe\wkssvc is blocked (ie. Chrome is running in a sandbox). BUG=700615, 660868 TBR=nasko NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2747873002 Cr-Commit-Position: refs/heads/master@{#456469} (cherry picked from commit bb0b93c87ade82c71918630893164754ea4a1f1e) Review-Url: https://codereview.chromium.org/2749863003 Cr-Commit-Position: refs/branch-heads/2987@{#823} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7e40940cf24e1f459433a1f7207217ee6b37958a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/renderer/render_process_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749863003/1
3 years, 9 months ago (2017-03-14 20:29:46 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-14 20:29:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749863003/1
3 years, 9 months ago (2017-03-14 20:31:02 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 20:36:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e40940cf24e1f459433a1f72072...

Powered by Google App Engine
This is Rietveld 408576698