Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2749863002: CSP: Prevent form-action to leak path on redirect. (Closed)

Created:
3 years, 9 months ago by arthursonzogni
Modified:
3 years, 9 months ago
Reviewers:
Mike West
CC:
alexmos, blink-reviews, chromium-reviews, clamy, nasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSP: Prevent form-action to leak path on redirect. The optional argument |redirectStatus| was forgotten. When a request is redirected, the Content-Security-Policy mustn't block a request depending on the path of the url, else an evil script could deduce the path the user gets redirected to. Test added to prevent further regression. BUG=701347 Review-Url: https://codereview.chromium.org/2749863002 Cr-Commit-Position: refs/heads/master@{#457060} Committed: https://chromium.googlesource.com/chromium/src/+/5c7a83e9da26f8621d4b17196c22c75fb1dca45f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-leak-path-on-redirect.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-leak-path-on-redirect-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
arthursonzogni
Hi Mike, Please could you take a look?
3 years, 9 months ago (2017-03-14 14:53:39 UTC) #4
Mike West
LGTM, thanks!
3 years, 9 months ago (2017-03-14 15:43:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749863002/1
3 years, 9 months ago (2017-03-15 12:30:45 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 12:34:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c7a83e9da26f8621d4b17196c22...

Powered by Google App Engine
This is Rietveld 408576698