Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2749843002: [grokdump] Fix typo in the search address form. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[grokdump] Fix typo in the search address form. Review-Url: https://codereview.chromium.org/2749843002 Cr-Commit-Position: refs/heads/master@{#43789} Committed: https://chromium.googlesource.com/v8/v8/+/32db0de4d9178727dfcf7597eeb431cc4f3df4bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/grokdump.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
This is the fix for the bug you have found. Please, take a look.
3 years, 9 months ago (2017-03-14 14:20:17 UTC) #4
neis
lgtm
3 years, 9 months ago (2017-03-14 14:21:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749843002/1
3 years, 9 months ago (2017-03-14 14:53:24 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 14:54:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/32db0de4d9178727dfcf7597eeb431cc4f3...

Powered by Google App Engine
This is Rietveld 408576698