Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2749773002: Remove AUTOSIZING_DOM_DEBUG_INFO sections (Closed)

Created:
3 years, 9 months ago by yuryu
Modified:
3 years, 9 months ago
Reviewers:
skobes
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AUTOSIZING_DOM_DEBUG_INFO sections from TextAutosizer TextAutosizer has AUTOSIZING_DOM_DEBUG_INFO macros to conditionally compile, but it doesn't compile when defined. The macro is not documented or integrated to the build system. It uses deprecated ExecutionContextTask there so this patch removes this conditional macro. BUG=625927, 701283 Review-Url: https://codereview.chromium.org/2749773002 Cr-Commit-Position: refs/heads/master@{#457012} Committed: https://chromium.googlesource.com/chromium/src/+/b231885a172263ba6e862e22819a3221140656eb

Patch Set 1 #

Patch Set 2 : remove AUTOSIZING_DOM_DEBUG_INFO parts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M third_party/WebKit/Source/core/layout/TextAutosizer.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 3 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yuryu
Hi, can you take a look? It seems that this AUTOSIZING_DOM_DEBUG_INFO is not used anymore, ...
3 years, 9 months ago (2017-03-15 04:59:15 UTC) #3
skobes
lgtm
3 years, 9 months ago (2017-03-15 05:07:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749773002/20001
3 years, 9 months ago (2017-03-15 06:19:50 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 06:26:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b231885a172263ba6e862e22819a...

Powered by Google App Engine
This is Rietveld 408576698