Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: ios/chrome/browser/ui/authentication/signin_promo_item.h

Issue 2749703003: Adding mediator for Sign-in promo (Closed)
Patch Set: Visual constraints Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/authentication/signin_promo_item.h
diff --git a/ios/chrome/browser/ui/authentication/signin_promo_item.h b/ios/chrome/browser/ui/authentication/signin_promo_item.h
new file mode 100644
index 0000000000000000000000000000000000000000..7313d28d5fc245bad0dcf70f39ee2ffebf3727d9
--- /dev/null
+++ b/ios/chrome/browser/ui/authentication/signin_promo_item.h
@@ -0,0 +1,40 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_ITEM_H_
+#define IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_ITEM_H_
+
+#import <UIKit/UIKit.h>
+
+#import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"
+#import "ios/third_party/material_components_ios/src/components/CollectionCells/src/MaterialCollectionCells.h"
+
+@class SigninPromoView;
+
lpromero 2017/03/24 10:36:19 Remove empty line.
jlebel 2017/03/24 20:59:08 Done.
+@protocol SigninPromoViewConfigurator;
+
+// SigninPromoItem is an item that configures a SigninPromoCell cell.
+@interface SigninPromoItem : CollectionViewItem
+
+// Configures the SigninPromoView view from SigninPromoCell.
+@property(nonatomic, weak) id<SigninPromoViewConfigurator>
+ signinPromoViewConfigurator;
msarda 2017/03/22 12:18:38 Optional nit: s/signinPromoViewConfigurator/config
lpromero 2017/03/24 10:36:19 +1
jlebel 2017/03/24 20:59:08 Done.
+
+- (instancetype)initWithType:(NSInteger)type
+ signinPromoViewConfigurator:
msarda 2017/03/22 12:18:38 Nit: s/signinPromoViewConfigurator/configurator fo
lpromero 2017/03/24 10:36:19 I would even just get rid of this initializer. Peo
jlebel 2017/03/24 20:59:08 Done.
+ (id<SigninPromoViewConfigurator>)signinPromoViewConfigurator
+ NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithType:(NSInteger)type NS_UNAVAILABLE;
+
+@end
+
+// Cell representation for SigninPromoItem. The cell contains only a
msarda 2017/03/22 12:18:38 s/. The cell contains ../, containing a single Sig
lpromero 2017/03/24 10:36:19 Disagreeing. The current comment is "more clearer"
jlebel 2017/03/24 20:59:08 Acknowledged.
+// SigninPromoView view.
+@interface SigninPromoCell : MDCCollectionViewCell
+
+@property(nonatomic, strong) SigninPromoView* signinPromoView;
+
+@end
+
+#endif // IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_ITEM_H_

Powered by Google App Engine
This is Rietveld 408576698