Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: ios/chrome/browser/ui/authentication/signin_promo_item.h

Issue 2749703003: Adding mediator for Sign-in promo (Closed)
Patch Set: Visual constraints Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_ITEM_H_
6 #define IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_ITEM_H_
7
8 #import <UIKit/UIKit.h>
9
10 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"
11 #import "ios/third_party/material_components_ios/src/components/CollectionCells/ src/MaterialCollectionCells.h"
12
13 @class SigninPromoView;
14
lpromero 2017/03/24 10:36:19 Remove empty line.
jlebel 2017/03/24 20:59:08 Done.
15 @protocol SigninPromoViewConfigurator;
16
17 // SigninPromoItem is an item that configures a SigninPromoCell cell.
18 @interface SigninPromoItem : CollectionViewItem
19
20 // Configures the SigninPromoView view from SigninPromoCell.
21 @property(nonatomic, weak) id<SigninPromoViewConfigurator>
22 signinPromoViewConfigurator;
msarda 2017/03/22 12:18:38 Optional nit: s/signinPromoViewConfigurator/config
lpromero 2017/03/24 10:36:19 +1
jlebel 2017/03/24 20:59:08 Done.
23
24 - (instancetype)initWithType:(NSInteger)type
25 signinPromoViewConfigurator:
msarda 2017/03/22 12:18:38 Nit: s/signinPromoViewConfigurator/configurator fo
lpromero 2017/03/24 10:36:19 I would even just get rid of this initializer. Peo
jlebel 2017/03/24 20:59:08 Done.
26 (id<SigninPromoViewConfigurator>)signinPromoViewConfigurator
27 NS_DESIGNATED_INITIALIZER;
28 - (instancetype)initWithType:(NSInteger)type NS_UNAVAILABLE;
29
30 @end
31
32 // Cell representation for SigninPromoItem. The cell contains only a
msarda 2017/03/22 12:18:38 s/. The cell contains ../, containing a single Sig
lpromero 2017/03/24 10:36:19 Disagreeing. The current comment is "more clearer"
jlebel 2017/03/24 20:59:08 Acknowledged.
33 // SigninPromoView view.
34 @interface SigninPromoCell : MDCCollectionViewCell
35
36 @property(nonatomic, strong) SigninPromoView* signinPromoView;
37
38 @end
39
40 #endif // IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_ITEM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698