Reland of Moving previews code from components/ to chrome/

Moving previews code from components/ to chrome/

Allows support for looking in other components or chrome code to verify
if a preview is enabled and check the previews version. The layering
dynamic is that components such as d_r_p will depend on previews/ and
not the other way around, so these methods should be moved to chrome/
and relevant information should be injected.

BUG=700459
Review-Url: https://codereview.chromium.org/2749693003
Cr-Commit-Position: refs/heads/master@{#456952}
Committed: https://chromium.googlesource.com/chromium/src/+/db539b8aaf2c0a5e3687f92dfba14a7036aa808f

[RyanSturm, 2017-03-14 18:51:53]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[RyanSturm, 2017-03-14 18:52:09]

Description was changed from

==========
Moving previews code from components/ to chrome/

Allows support for looking in other components or chrome code to verify
if a preview is enabled and check the previews version. The layering
dynamic is that components such as d_r_p will depend on previews/ and
not the other way around, so these methods should be moved to chrome/
and relevant information should be injected.

BUG=700459
==========

to

==========
Moving previews code from components/ to chrome/

Allows support for looking in other components or chrome code to verify
if a preview is enabled and check the previews version. The layering
dynamic is that components such as d_r_p will depend on previews/ and
not the other way around, so these methods should be moved to chrome/
and relevant information should be injected.

BUG=700459
==========

[commit-bot: I haz the power, 2017-03-14 18:52:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-03-14 18:53:03]

ryansturm@chromium.org changed reviewers:
+ tbansal@chromium.org

[RyanSturm, 2017-03-14 18:53:04]

tbansal: PTAL

[commit-bot: I haz the power, 2017-03-14 20:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:12:11]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-03-14 20:48:37]

https://codereview.chromium.org/2749693003/diff/20001/components/previews/cor...
File components/previews/core/previews_opt_out_store_sql.cc (right):

https://codereview.chromium.org/2749693003/diff/20001/components/previews/cor...
components/previews/core/previews_opt_out_store_sql.cc:451: for (const auto
preview : *enabled_previews_) {
rm parens.

https://codereview.chromium.org/2749693003/diff/20001/components/previews/cor...
components/previews/core/previews_opt_out_store_sql.cc:451: for (const auto
preview : *enabled_previews_) {
Can you add a comment why copying is needed?

Also, you may want to call:
enabled_previews->reserve(enabled_previews_.size());
to reduce repeated memory allocations.

[RyanSturm, 2017-03-14 20:56:22]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 20:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-03-14 20:57:28]

https://codereview.chromium.org/2749693003/diff/20001/components/previews/cor...
File components/previews/core/previews_opt_out_store_sql.cc (right):

https://codereview.chromium.org/2749693003/diff/20001/components/previews/cor...
components/previews/core/previews_opt_out_store_sql.cc:451: for (const auto
preview : *enabled_previews_) {
On 2017/03/14 20:48:36, tbansal1 wrote:
> rm parens.

Done.

https://codereview.chromium.org/2749693003/diff/20001/components/previews/cor...
components/previews/core/previews_opt_out_store_sql.cc:451: for (const auto
preview : *enabled_previews_) {
On 2017/03/14 20:48:36, tbansal1 wrote:
> Can you add a comment why copying is needed?
> 
> Also, you may want to call:
> enabled_previews->reserve(enabled_previews_.size());
> to reduce repeated memory allocations.

Done.

[tbansal1, 2017-03-14 20:58:44]

lgtm

[commit-bot: I haz the power, 2017-03-14 21:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 21:50:38]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-03-15 02:03:51]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:04:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:14:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489543431368690,
"parent_rev": "e4d8d06349a9454d77ccdb1a2e2bdfdf085fd044", "commit_rev":
"db539b8aaf2c0a5e3687f92dfba14a7036aa808f"}

[commit-bot: I haz the power, 2017-03-15 02:14:41]

Description was changed from

==========
Moving previews code from components/ to chrome/

Allows support for looking in other components or chrome code to verify
if a preview is enabled and check the previews version. The layering
dynamic is that components such as d_r_p will depend on previews/ and
not the other way around, so these methods should be moved to chrome/
and relevant information should be injected.

BUG=700459
==========

to

==========
Moving previews code from components/ to chrome/

Allows support for looking in other components or chrome code to verify
if a preview is enabled and check the previews version. The layering
dynamic is that components such as d_r_p will depend on previews/ and
not the other way around, so these methods should be moved to chrome/
and relevant information should be injected.

BUG=700459

Review-Url: https://codereview.chromium.org/2749693003
Cr-Commit-Position: refs/heads/master@{#456952}
Committed:
https://chromium.googlesource.com/chromium/src/+/db539b8aaf2c0a5e3687f92dfba1...
==========

[commit-bot: I haz the power, 2017-03-15 02:14:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/db539b8aaf2c0a5e3687f92dfba1...