Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2749693002: Chrome OS: Add 'Cancel" icon in 'Add an account' screen in multiprofile mode. (Closed)

Created:
3 years, 9 months ago by xdai1
Modified:
3 years, 9 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS: Add 'Cancel" icon in 'Add an account' screen in multiprofile mode. BUG=698162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2749693002 Cr-Commit-Position: refs/heads/master@{#456748} Committed: https://chromium.googlesource.com/chromium/src/+/be6ebc51ed8da2adfd4d0db540c0df394f8dd4d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/header_bar.css View 1 chunk +3 lines, -2 lines 0 comments Download
A chrome/browser/resources/chromeos/login/images/1x/cancel.svg View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/images/2x/cancel.svg View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
xdai1
alemate@, could you help review this CL please? Thanks!
3 years, 9 months ago (2017-03-13 22:54:23 UTC) #3
Alexander Alekseev
lgtm wit nit: please clarify your commit message. Did you mean "Multiprofile mode" ?
3 years, 9 months ago (2017-03-14 01:31:41 UTC) #8
xdai1
On 2017/03/14 01:31:41, Alexander Alekseev wrote: > lgtm wit nit: please clarify your commit message. ...
3 years, 9 months ago (2017-03-14 16:37:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749693002/1
3 years, 9 months ago (2017-03-14 16:38:26 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 17:20:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be6ebc51ed8da2adfd4d0db540c0...

Powered by Google App Engine
This is Rietveld 408576698