Prototype HTMLVideoElement properties for WebGL texImage2D

media/blink/webmediaplayer_impl.h

Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 308da411abec8e9cb90ac8c3f6d0d6630918348a..fc892c4be9bf77220570127830935f61afd9d53d 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -140,6 +140,10 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   void selectedVideoTrackChanged(
       blink::WebMediaPlayer::TrackId* selectedTrackId) override;
 
+  bool getLastUploadedFrameInfo(unsigned* width,
+                                unsigned* height,
+                                double* timestamp) override;
+
   // Dimensions of the video.
   blink::WebSize naturalSize() const override;
 
@@ -452,6 +456,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   // handling a src= or MSE based playback.
   void RecordUnderflowDuration(base::TimeDelta duration);
 
+  // Updates the cached video frame info for getLastUploadedFrameInfo.

[DaleCurtis, 2017/03/15 22:53:50]

No need for method, just update at call site for get current frame.

[Ken Russell (switch to Gerrit), 2017/03/16 00:57:43]

Thanks. The idea was to minimize the number of places where this would be done,
but if it's OK to do it all the time in GetCurrentFrameFromCompositor, that's
even easier.

[Kai Ninomiya, 2017/03/16 22:28:25]

dalecurtis: Are you suggesting updating the (now 2) variables outside or inside
GetCurrentFrameFromCompositor?

It's possible we may end up needing to change the set of last-uploaded
variables, so I'd rather keep it in one place. Either
UpdateLastUploadedFrameInfo, or inside GetCurrentFrameFromCompositor.

[DaleCurtis, 2017/03/16 22:30:02]

Inside.

[Kai Ninomiya, 2017/03/17 21:40:15]

Done.

+  void UpdateLastUploadedFrameInfo(VideoFrame*);
+
   blink::WebLocalFrame* frame_;
 
   // The playback state last reported to |delegate_|, to avoid setting duplicate
@@ -710,6 +717,10 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   // Whether embedded media experience is currently enabled.
   bool embedded_media_experience_enabled_ = false;
 
+  unsigned last_uploaded_frame_width_ = 0;

[DaleCurtis, 2017/03/15 22:53:50]

gfx::Size and TimeDelta

[Kai Ninomiya, 2017/03/16 22:28:25]

Acknowledged.

[Kai Ninomiya, 2017/03/17 21:40:15]

Done.

+  unsigned last_uploaded_frame_height_ = 0;
+  double last_uploaded_frame_timestamp_ = 0.0;
+
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
 };