Prototype HTMLVideoElement properties for WebGL texImage2D

media/blink/webmediaplayer_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 122 matching lines @@
   // True if the loaded media has a playable video/audio track.
   bool hasVideo() const override;
   bool hasAudio() const override;
 
   void enabledAudioTracksChanged(
       const blink::WebVector<blink::WebMediaPlayer::TrackId>& enabledTrackIds)
       override;
   void selectedVideoTrackChanged(
       blink::WebMediaPlayer::TrackId* selectedTrackId) override;
 
+  bool getLastUploadedFrameInfo(unsigned* width,
+                                unsigned* height,
+                                double* timestamp) override;
+
   // Dimensions of the video.
   blink::WebSize naturalSize() const override;
 
   // Getters of playback state.
   bool paused() const override;
   bool seeking() const override;
   double duration() const override;
   virtual double timelineOffset() const;
   double currentTime() const override;
 
@@ skipping 292 matching lines @@
   // Return the pipeline media duration or the value overridden by tests.
   base::TimeDelta GetPipelineMediaDuration() const;
 
   void ReportTimeFromForegroundToFirstFrame(base::TimeTicks foreground_time,
                                             base::TimeTicks new_frame_time);
 
   // Records |duration| to the appropriate metric based on whether we're
   // handling a src= or MSE based playback.
   void RecordUnderflowDuration(base::TimeDelta duration);
 
+  // Updates the cached video frame info for getLastUploadedFrameInfo.

[DaleCurtis, 2017/03/15 22:53:50]

No need for method, just update at call site for get current frame.

[Ken Russell (switch to Gerrit), 2017/03/16 00:57:43]

Thanks. The idea was to minimize the number of places where this would be done,
but if it's OK to do it all the time in GetCurrentFrameFromCompositor, that's
even easier.

[Kai Ninomiya, 2017/03/16 22:28:25]

dalecurtis: Are you suggesting updating the (now 2) variables outside or inside
GetCurrentFrameFromCompositor?

It's possible we may end up needing to change the set of last-uploaded
variables, so I'd rather keep it in one place. Either
UpdateLastUploadedFrameInfo, or inside GetCurrentFrameFromCompositor.

[DaleCurtis, 2017/03/16 22:30:02]

Inside.

[Kai Ninomiya, 2017/03/17 21:40:15]

Done.

+  void UpdateLastUploadedFrameInfo(VideoFrame*);
+
   blink::WebLocalFrame* frame_;
 
   // The playback state last reported to |delegate_|, to avoid setting duplicate
   // states.
   // TODO(sandersd): The delegate should be implementing deduplication.
   DelegateState delegate_state_;
   bool delegate_has_audio_;
 
   blink::WebMediaPlayer::NetworkState network_state_;
   blink::WebMediaPlayer::ReadyState ready_state_;
@@ skipping 238 matching lines @@
   // Pipeline media duration overridden by tests.
   base::Optional<base::TimeDelta> pipeline_media_duration_for_test_;
 
   // Whether the video requires a user gesture to resume after it was paused in
   // the background. Affects the value of ShouldPauseVideoWhenHidden().
   bool video_locked_when_paused_when_hidden_ = false;
 
   // Whether embedded media experience is currently enabled.
   bool embedded_media_experience_enabled_ = false;
 
+  unsigned last_uploaded_frame_width_ = 0;

[DaleCurtis, 2017/03/15 22:53:50]

gfx::Size and TimeDelta

[Kai Ninomiya, 2017/03/16 22:28:25]

Acknowledged.

[Kai Ninomiya, 2017/03/17 21:40:15]

Done.

+  unsigned last_uploaded_frame_height_ = 0;
+  double last_uploaded_frame_timestamp_ = 0.0;
+
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_