allow unit_tests to re-create service manager context.

allow unit_tests to re-create service manager context.

ServiceManagerContext is designed to be created only once. However in
unit tests in batch mode TestServiceManagerContext might be recreated
many times for the same process. This calls several asserts. This CL
resets static files association after destroying
TestServiceManagerContext

TEST=unit_tests passes, number of retry tests changed 81->4 time
     from 256 seconds to 88.
BUG=693559
Review-Url: https://codereview.chromium.org/2749653002
Cr-Commit-Position: refs/heads/master@{#456517}
Committed: https://chromium.googlesource.com/chromium/src/+/1a2563dcc211e71fa8c32f52c9bc4d64d71a42cc

[khmel, 2017-03-13 20:48:45]

The CQ bit was checked by khmel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 20:49:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[khmel, 2017-03-13 20:57:58]

khmel@chromium.org changed reviewers:
+ dgozman@chromium.org

[khmel, 2017-03-13 20:57:58]

Hi,

PTAL

Thanks!

[dgozman, 2017-03-13 21:29:37]

dgozman@chromium.org changed reviewers:
+ rockot@chromium.org

[dgozman, 2017-03-13 21:29:38]

rs lgtm for content/, deferring to rockot@ for the real review.

https://codereview.chromium.org/2749653002/diff/1/content/browser/child_proce...
File content/browser/child_process_launcher_helper_posix.h (right):

https://codereview.chromium.org/2749653002/diff/1/content/browser/child_proce...
content/browser/child_process_launcher_helper_posix.h:46: // Called by the
TestServiceManagerContext to reset all previously registered
nit: don't mention class names in comments, they tend to become outdated.

[Ken Rockot(use gerrit already), 2017-03-13 21:46:56]

LGTM

[khmel, 2017-03-13 21:53:04]

Thank you for quick review!

https://codereview.chromium.org/2749653002/diff/1/content/browser/child_proce...
File content/browser/child_process_launcher_helper_posix.h (right):

https://codereview.chromium.org/2749653002/diff/1/content/browser/child_proce...
content/browser/child_process_launcher_helper_posix.h:46: // Called by the
TestServiceManagerContext to reset all previously registered
On 2017/03/13 21:29:38, dgozman wrote:
> nit: don't mention class names in comments, they tend to become outdated.

Good point, done.

[khmel, 2017-03-13 21:53:08]

The CQ bit was checked by khmel@chromium.org

[khmel, 2017-03-13 21:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2749653002/#ps20001
(title: "comment updated")

[commit-bot: I haz the power, 2017-03-13 21:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 22:51:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489441988763600,
"parent_rev": "154bd6255e4403f971f41431d0ea19f2710d569a", "commit_rev":
"1a2563dcc211e71fa8c32f52c9bc4d64d71a42cc"}

[commit-bot: I haz the power, 2017-03-13 22:52:03]

Description was changed from

==========
allow unit_tests to re-create service manager context.

ServiceManagerContext is designed to be created only once. However in
unit tests in batch mode TestServiceManagerContext might be recreated
many times for the same process. This calls several asserts. This CL
resets static files association after destroying
TestServiceManagerContext

TEST=unit_tests passes, number of retry tests changed 81->4 time
     from 256 seconds to 88.
BUG=693559
==========

to

==========
allow unit_tests to re-create service manager context.

ServiceManagerContext is designed to be created only once. However in
unit tests in batch mode TestServiceManagerContext might be recreated
many times for the same process. This calls several asserts. This CL
resets static files association after destroying
TestServiceManagerContext

TEST=unit_tests passes, number of retry tests changed 81->4 time
     from 256 seconds to 88.
BUG=693559

Review-Url: https://codereview.chromium.org/2749653002
Cr-Commit-Position: refs/heads/master@{#456517}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a2563dcc211e71fa8c32f52c9bc...
==========

[commit-bot: I haz the power, 2017-03-13 22:52:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a2563dcc211e71fa8c32f52c9bc...