Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2749623003: Revert "Add support for metadata on type variables to Fasta parser." (Closed)

Created:
3 years, 9 months ago by Paul Berry
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add support for metadata on type variables to Fasta parser." This caused test failures. See for example: https://build.chromium.org/p/client.dart/builders/vm-kernel-linux-release-x64-be/builds/1641 This reverts commit 5d8d01cdf737a662bf83ce72938ea3750da57acb. TBR=ahe@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/71304714d4616538391d1902b11388adeac045b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -78 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 3 chunks +2 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 2 chunks +3 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 2 chunks +3 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Paul Berry
Committed patchset #1 (id:1) manually as 71304714d4616538391d1902b11388adeac045b9 (presubmit successful).
3 years, 9 months ago (2017-03-13 19:29:44 UTC) #2
Siggi Cherem (dart-lang)
3 years, 9 months ago (2017-03-13 21:57:21 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698