Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2749623003: Revert "Add support for metadata on type variables to Fasta parser." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.outline_builder; 5 library fasta.outline_builder;
6 6
7 import 'package:kernel/ast.dart' show AsyncMarker, ProcedureKind; 7 import 'package:kernel/ast.dart' show AsyncMarker, ProcedureKind;
8 8
9 import '../parser/parser.dart' show FormalParameterType, optional; 9 import '../parser/parser.dart' show FormalParameterType, optional;
10 10
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 int modifiers = Modifier.validate(pop()); 565 int modifiers = Modifier.validate(pop());
566 List<MetadataBuilder> metadata = pop(); 566 List<MetadataBuilder> metadata = pop();
567 library.addFields(metadata, modifiers, type, names); 567 library.addFields(metadata, modifiers, type, names);
568 } 568 }
569 569
570 @override 570 @override
571 void endTypeVariable(Token token, Token extendsOrSuper) { 571 void endTypeVariable(Token token, Token extendsOrSuper) {
572 debugEvent("endTypeVariable"); 572 debugEvent("endTypeVariable");
573 TypeBuilder bound = pop(); 573 TypeBuilder bound = pop();
574 String name = pop(); 574 String name = pop();
575 // TODO(paulberry): type variable metadata should not be ignored. See
576 // dartbug.com/28981.
577 /* List<MetadataBuilder> metadata = */ pop();
578 push(library.addTypeVariable(name, bound, token.charOffset)); 575 push(library.addTypeVariable(name, bound, token.charOffset));
579 } 576 }
580 577
581 @override 578 @override
582 void endPartOf(Token partKeyword, Token semicolon) { 579 void endPartOf(Token partKeyword, Token semicolon) {
583 debugEvent("endPartOf"); 580 debugEvent("endPartOf");
584 String name = pop(); 581 String name = pop();
585 List<MetadataBuilder> metadata = pop(); 582 List<MetadataBuilder> metadata = pop();
586 library.addPartOf(metadata, name); 583 library.addPartOf(metadata, name);
587 } 584 }
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 Link<Token> handleMemberName(Link<Token> identifiers) { 700 Link<Token> handleMemberName(Link<Token> identifiers) {
704 if (!isDartLibrary || identifiers.isEmpty) return identifiers; 701 if (!isDartLibrary || identifiers.isEmpty) return identifiers;
705 return removeNativeClause(identifiers); 702 return removeNativeClause(identifiers);
706 } 703 }
707 704
708 @override 705 @override
709 void debugEvent(String name) { 706 void debugEvent(String name) {
710 // printEvent(name); 707 // printEvent(name);
711 } 708 }
712 } 709 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698