third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp - Issue 2749593002: Remove argument to LayoutSVGResourceGradient::collectGradientAttributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

Issue 2749593002: Remove argument to LayoutSVGResourceGradient::collectGradientAttributes (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceRadialGradient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

index 5afa09385318d88a4e43bdc452f2b7807d40028a..fd476fab394a3f7f0ac9892136fb58601dc7f742 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

@@ -136,6 +136,10 @@ SVGPaintServer LayoutSVGResourcePattern::preparePaintServer(

if (!patternElement)

return SVGPaintServer::invalid();

+ // Validate patter DOM state before building the actual

+ // pattern. This should avoid tearing down the pattern we're

+ // currently working on. Preferably the state validation should have

+ // no side-effects though.

if (m_shouldCollectPatternAttributes) {

patternElement->synchronizeAnimatedSVGAttribute(anyQName());