third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp - Issue 2749593002: Remove argument to LayoutSVGResourceGradient::collectGradientAttributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

Issue 2749593002: Remove argument to LayoutSVGResourceGradient::collectGradientAttributes (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

index 7d231501329320746263d5773f2bf4beb0ed5e99..d79ca19dd40aa535de55ed6a62f56ac28d71a5aa 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

@@ -31,11 +31,11 @@ LayoutSVGResourceLinearGradient::LayoutSVGResourceLinearGradient(

LayoutSVGResourceLinearGradient::~LayoutSVGResourceLinearGradient() {}

-bool LayoutSVGResourceLinearGradient::collectGradientAttributes(

- SVGGradientElement* gradientElement) {

+bool LayoutSVGResourceLinearGradient::collectGradientAttributes() {

+ DCHECK(element());

m_attributesWrapper->set(LinearGradientAttributes());

- return toSVGLinearGradientElement(gradientElement)

- ->collectGradientAttributes(mutableAttributes());

+ return toSVGLinearGradientElement(element())->collectGradientAttributes(

+ mutableAttributes());

}

FloatPoint LayoutSVGResourceLinearGradient::startPoint(