Remove argument to LayoutSVGResourceGradient::collectGradientAttributes

third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
index de3646c58a3195f7f77d256807fc5f6c77a3b426..f6ce9cf8612d82f6e887ba834b1f82249b6606eb 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
@@ -52,21 +52,9 @@ SVGPaintServer LayoutSVGResourceGradient::preparePaintServer(
     const LayoutObject& object) {
   clearInvalidationMask();
 
-  // Be sure to synchronize all SVG properties on the gradientElement _before_

[pdr., 2017/03/13 18:36:31]

Do we have a comment describing the current system anywhere? If not, think you
could add a short one (probably not here, not sure where)?

[fs, 2017/03/13 18:44:47]

That's a good question, I suspect there is none... I'll see if I can figure
somewhere to put something.

[fs, 2017/03/13 19:54:45]

Kept the new comment in the same place. Added a similar one for the <pattern>
case.

-  // processing any further. Otherwhise the call to collectGradientAttributes()
-  // in createTileImage(), may cause the SVG DOM property synchronization to
-  // kick in, which causes removeAllClientsFromCache() to be called, which in
-  // turn deletes our GradientData object! Leaving out the line below will cause
-  // svg/dynamic-updates/SVG*GradientElement-svgdom* to crash.
-  SVGGradientElement* gradientElement = toSVGGradientElement(element());
-  if (!gradientElement)
-    return SVGPaintServer::invalid();
-
   if (m_shouldCollectGradientAttributes) {
-    gradientElement->synchronizeAnimatedSVGAttribute(anyQName());
-    if (!collectGradientAttributes(gradientElement))
+    if (!collectGradientAttributes())
       return SVGPaintServer::invalid();
-
     m_shouldCollectGradientAttributes = false;
   }