third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h - Issue 2749593002: Remove argument to LayoutSVGResourceGradient::collectGradientAttributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h

Issue 2749593002: Remove argument to LayoutSVGResourceGradient::collectGradientAttributes (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h

index 63d68c91b30812a2cc35e386a392785aed1d23e4..179bd44b903b9765a558a082ddd9759eb3379af6 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h

@@ -24,7 +24,6 @@

#include "core/layout/svg/LayoutSVGResourcePaintServer.h"

#include "core/svg/SVGGradientElement.h"

-#include "platform/geometry/FloatRect.h"

#include "platform/graphics/Gradient.h"

#include "platform/transforms/AffineTransform.h"

#include "wtf/HashMap.h"

@@ -57,7 +56,7 @@ class LayoutSVGResourceGradient : public LayoutSVGResourcePaintServer {

virtual SVGUnitTypes::SVGUnitType gradientUnits() const = 0;

virtual AffineTransform calculateGradientTransform() const = 0;

- virtual bool collectGradientAttributes(SVGGradientElement*) = 0;

+ virtual bool collectGradientAttributes() = 0;

virtual PassRefPtr<Gradient> buildGradient() const = 0;

static GradientSpreadMethod platformSpreadMethodFromSVGType(