Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2749583002: Add Gradient::addColorStops method (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
CC:
fs, ajuma+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Gradient::addColorStops method This seems a better fit on Gradient than on LayoutSVGResourceGradient. Review-Url: https://codereview.chromium.org/2749583002 Cr-Commit-Position: refs/heads/master@{#456504} Committed: https://chromium.googlesource.com/chromium/src/+/039925aca6bafdd0db4044b1285311e43c6588f8

Patch Set 1 #

Messages

Total messages: 16 (10 generated)
fs
3 years, 9 months ago (2017-03-13 18:33:45 UTC) #6
f(malita)
lgtm
3 years, 9 months ago (2017-03-13 18:38:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749583002/1
3 years, 9 months ago (2017-03-13 18:41:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/382204)
3 years, 9 months ago (2017-03-13 20:04:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749583002/1
3 years, 9 months ago (2017-03-13 21:36:57 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 22:10:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/039925aca6bafdd0db4044b12853...

Powered by Google App Engine
This is Rietveld 408576698