Remove header ordering checks from check-webkit-style

Remove header ordering checks from check-webkit-style

This change removes checks for header ordering in check-webkit-style.
We use clang-format to format and lint our headers so it is unnecessary
for check-webkit-style to check this.

See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
something linted by clang-format that would fail check-webkit-style
if this feature weren't removed.

BUG=701250
Review-Url: https://codereview.chromium.org/2749513008
Cr-Commit-Position: refs/heads/master@{#458009}
Committed: https://chromium.googlesource.com/chromium/src/+/2a9fb0166f08fecc7b3b68deff1b6523f1610d23

[alancutter (OOO until 2018), 2017-03-16 03:51:19]

alancutter@chromium.org changed reviewers:
+ dcheng@chromium.org

[alancutter (OOO until 2018), 2017-03-16 05:36:48]

Description was changed from

==========
Make primary header classification require exact base name match

This change removes the "lenient" primary header matching classification
that occurs outside of the primary header section.
This change is required to allow unit tests that don't have headers to
include headers that have "lenient" matching with themselves.

BUG=701250
==========

to

==========
Make primary header classification require exact base name match

This change removes the "lenient" primary header matching classification
that occurs outside of the primary header section.
This change is required to allow unit tests that don't have headers to
include headers that have "lenient" matching with themselves.

See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
something that would fail check-webkit-style without this change.

BUG=701250
==========

[dcheng, 2017-03-16 05:45:27]

On 2017/03/16 05:36:48, alancutter wrote:
> Description was changed from
> 
> ==========
> Make primary header classification require exact base name match
> 
> This change removes the "lenient" primary header matching classification
> that occurs outside of the primary header section.
> This change is required to allow unit tests that don't have headers to
> include headers that have "lenient" matching with themselves.
> 
> BUG=701250
> ==========
> 
> to
> 
> ==========
> Make primary header classification require exact base name match
> 
> This change removes the "lenient" primary header matching classification
> that occurs outside of the primary header section.
> This change is required to allow unit tests that don't have headers to
> include headers that have "lenient" matching with themselves.
> 
> See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
> something that would fail check-webkit-style without this change.
> 
> BUG=701250
> ==========

Since we have clang-format #include sorting, I wonder if we should just remove
this altogether? That way, we don't get instances where the C++ style checker
and clang-format disagree.

[alancutter (OOO until 2018), 2017-03-17 00:54:14]

Description was changed from

==========
Make primary header classification require exact base name match

This change removes the "lenient" primary header matching classification
that occurs outside of the primary header section.
This change is required to allow unit tests that don't have headers to
include headers that have "lenient" matching with themselves.

See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
something that would fail check-webkit-style without this change.

BUG=701250
==========

to

==========
Remove header ordering checks from check-webkit-style

This change removes checks for header ordering in check-webkit-style.
We use clang-format to format and lint our headers so it is unnecessary
for check-webkit-style to check this.

See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
something linted by clang-format that would fail check-webkit-style
if this feature weren't removed.

BUG=701250
==========

[alancutter (OOO until 2018), 2017-03-17 00:54:28]

On 2017/03/16 at 05:45:27, dcheng wrote:
> On 2017/03/16 05:36:48, alancutter wrote:
> > Description was changed from
> > 
> > ==========
> > Make primary header classification require exact base name match
> > 
> > This change removes the "lenient" primary header matching classification
> > that occurs outside of the primary header section.
> > This change is required to allow unit tests that don't have headers to
> > include headers that have "lenient" matching with themselves.
> > 
> > BUG=701250
> > ==========
> > 
> > to
> > 
> > ==========
> > Make primary header classification require exact base name match
> > 
> > This change removes the "lenient" primary header matching classification
> > that occurs outside of the primary header section.
> > This change is required to allow unit tests that don't have headers to
> > include headers that have "lenient" matching with themselves.
> > 
> > See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
> > something that would fail check-webkit-style without this change.
> > 
> > BUG=701250
> > ==========
> 
> Since we have clang-format #include sorting, I wonder if we should just remove
this altogether? That way, we don't get instances where the C++ style checker
and clang-format disagree.

Excellent idea, updated patch.

[dcheng, 2017-03-17 05:37:30]

LGTM with nits

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2572:
primary_header_exists = _does_primary_header_exist(filename)
I think this can be removed (and possibly header_type/header_types below as
well)

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
(right):

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2231:
def test_check_next_include_order__likely_then_config(self):
I think these three tests can be removed as well

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2286:
def test_try_drop_common_suffixes(self):
Perhaps this one too.

[alancutter (OOO until 2018), 2017-03-19 23:12:48]

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2572:
primary_header_exists = _does_primary_header_exist(filename)
On 2017/03/17 at 05:37:29, dcheng wrote:
> I think this can be removed (and possibly header_type/header_types below as
well)

Yep, removed.

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
(right):

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2231:
def test_check_next_include_order__likely_then_config(self):
On 2017/03/17 at 05:37:29, dcheng wrote:
> I think these three tests can be removed as well

Done. Removed the function they tested as well as it was unused.

https://codereview.chromium.org/2749513008/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2286:
def test_try_drop_common_suffixes(self):
On 2017/03/17 at 05:37:30, dcheng wrote:
> Perhaps this one too.


Done. Removed the function it tested as well as it was unused.

[alancutter (OOO until 2018), 2017-03-19 23:14:23]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-03-19 23:14:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2749513008/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2017-03-19 23:14:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 00:42:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489965263120360,
"parent_rev": "eced643651fe8ffb34e30487cd698fa886918c53", "commit_rev":
"2a9fb0166f08fecc7b3b68deff1b6523f1610d23"}

[commit-bot: I haz the power, 2017-03-20 00:44:12]

Description was changed from

==========
Remove header ordering checks from check-webkit-style

This change removes checks for header ordering in check-webkit-style.
We use clang-format to format and lint our headers so it is unnecessary
for check-webkit-style to check this.

See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
something linted by clang-format that would fail check-webkit-style
if this feature weren't removed.

BUG=701250
==========

to

==========
Remove header ordering checks from check-webkit-style

This change removes checks for header ordering in check-webkit-style.
We use clang-format to format and lint our headers so it is unnecessary
for check-webkit-style to check this.

See AnimationSimTest.cpp in https://codereview.chromium.org/2757543002 for
something linted by clang-format that would fail check-webkit-style
if this feature weren't removed.

BUG=701250

Review-Url: https://codereview.chromium.org/2749513008
Cr-Commit-Position: refs/heads/master@{#458009}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a9fb0166f08fecc7b3b68deff1b...
==========

[commit-bot: I haz the power, 2017-03-20 00:44:13]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2a9fb0166f08fecc7b3b68deff1b...