Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2749423003:
DevTools: launch What's New from experiments (Closed)
|
Created:
3 years, 9 months ago by chenwilliam Modified:
3 years, 8 months ago Reviewers:
alph CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: launch What's New from experiments
This is intended to gather feedback in Canary and then
we'll add another set of release notes before the next branch point.
BUG=682879, 702512
Review-Url: https://codereview.chromium.org/2749423003
Cr-Original-Commit-Position: refs/heads/master@{#457598}
Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc158c60939220
Review-Url: https://codereview.chromium.org/2749423003
Cr-Commit-Position: refs/heads/master@{#460234}
Committed: https://chromium.googlesource.com/chromium/src/+/aa93df3943c70cef817a33f3b2fdb377598774ba
Patch Set 1 #Patch Set 2 : patched #
Messages
Total messages: 29 (16 generated)
chenwilliam@chromium.org changed reviewers: + alph@chromium.org
@alph - it's here :)
lgtm
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489696354002460, "parent_rev":
"eeaca73ad3f97a71c35c8298ccf691ebad35161d", "commit_rev":
"9f061aa07fd7c89d8f1b0c3ddedc158c60939220"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879 ========== to ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879 Review-Url: https://codereview.chromium.org/2749423003 Cr-Commit-Position: refs/heads/master@{#457598} Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2759223002/ by alph@chromium.org. The reason for reverting is: It needs more UX work..
Message was sent while issue was closed.
Description was changed from ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879 Review-Url: https://codereview.chromium.org/2749423003 Cr-Commit-Position: refs/heads/master@{#457598} Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc... ========== to ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879 Review-Url: https://codereview.chromium.org/2749423003 Cr-Commit-Position: refs/heads/master@{#457598} Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc... ==========
Description was changed from ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879 Review-Url: https://codereview.chromium.org/2749423003 Cr-Commit-Position: refs/heads/master@{#457598} Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc... ========== to ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879, 702512 Review-Url: https://codereview.chromium.org/2749423003 Cr-Commit-Position: refs/heads/master@{#457598} Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc... ==========
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by chenwilliam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org Link to the patchset: https://codereview.chromium.org/2749423003/#ps20001 (title: "patched")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ has no permission to schedule in bucket master.tryserver.chromium.linux
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490740239277600,
"parent_rev": "0e617010e8d0f3c87e3487a4a7d5326f34b7265c", "commit_rev":
"aa93df3943c70cef817a33f3b2fdb377598774ba"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879, 702512 Review-Url: https://codereview.chromium.org/2749423003 Cr-Commit-Position: refs/heads/master@{#457598} Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc... ========== to ========== DevTools: launch What's New from experiments This is intended to gather feedback in Canary and then we'll add another set of release notes before the next branch point. BUG=682879, 702512 Review-Url: https://codereview.chromium.org/2749423003 Cr-Original-Commit-Position: refs/heads/master@{#457598} Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc... Review-Url: https://codereview.chromium.org/2749423003 Cr-Commit-Position: refs/heads/master@{#460234} Committed: https://chromium.googlesource.com/chromium/src/+/aa93df3943c70cef817a33f3b2fd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/aa93df3943c70cef817a33f3b2fd... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
