Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2749423002: [Devtools] Renamed _loadColumns and _saveColumns to be more appropriate (Closed)

Created:
3 years, 9 months ago by allada
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Renamed _loadColumns and _saveColumns to be more appropriate This patch simply renames these two functions in LogViewColumns because the names did not describe if they were doing it to all columns or just custom columns. R=caseq BUG=None Review-Url: https://codereview.chromium.org/2749423002 Cr-Commit-Position: refs/heads/master@{#457278} Committed: https://chromium.googlesource.com/chromium/src/+/230a0e4bf0f499014e288e06d40264f4123a637a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 5 chunks +7 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
allada
PTL - I will be introducing some new functions similar to these functions in an ...
3 years, 9 months ago (2017-03-15 21:05:31 UTC) #2
caseq
lgtm, though I don't see anything inappropriate about old names :-)
3 years, 9 months ago (2017-03-15 21:17:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749423002/1
3 years, 9 months ago (2017-03-16 00:13:41 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 00:22:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/230a0e4bf0f499014e288e06d402...

Powered by Google App Engine
This is Rietveld 408576698