Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2749413002: Add leak expectation for external/wpt/.../window-synthetic-errorevent.html. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
tkent, domenic
CC:
blink-reviews, chromium-reviews, Henrik Grunell, tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add leak expectation for external/wpt/.../window-synthetic-errorevent.html. BUG=701695 Review-Url: https://codereview.chromium.org/2749413002 Cr-Commit-Position: refs/heads/master@{#457256} Committed: https://chromium.googlesource.com/chromium/src/+/3a8dda52afa9518898222bf0781add1243e2a33e

Patch Set 1 #

Patch Set 2 : Add leak expectation for external/wpt/.../window-synthetic-errorevent.html. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
qyearsley
3 years, 9 months ago (2017-03-15 20:38:34 UTC) #4
domenic
On 2017/03/15 at 20:38:34, qyearsley wrote: > I am 95% sure the underlying bug here ...
3 years, 9 months ago (2017-03-15 21:14:01 UTC) #5
qyearsley
On 2017/03/15 at 21:14:01, domenic wrote: > On 2017/03/15 at 20:38:34, qyearsley wrote: > > ...
3 years, 9 months ago (2017-03-15 21:37:11 UTC) #6
qyearsley
OK to commit?
3 years, 9 months ago (2017-03-15 21:47:12 UTC) #9
tkent
lgtm
3 years, 9 months ago (2017-03-15 22:19:26 UTC) #13
domenic
lgtm
3 years, 9 months ago (2017-03-15 22:20:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749413002/20001
3 years, 9 months ago (2017-03-15 23:00:16 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 23:14:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a8dda52afa9518898222bf0781a...

Powered by Google App Engine
This is Rietveld 408576698