|
|
Chromium Code Reviews
DescriptionAdd leak expectation for external/wpt/.../window-synthetic-errorevent.html.
BUG=701695
Review-Url: https://codereview.chromium.org/2749413002
Cr-Commit-Position: refs/heads/master@{#457256}
Committed: https://chromium.googlesource.com/chromium/src/+/3a8dda52afa9518898222bf0781add1243e2a33e
Patch Set 1 #Patch Set 2 : Add leak expectation for external/wpt/.../window-synthetic-errorevent.html. #Messages
Total messages: 20 (12 generated)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
qyearsley@chromium.org changed reviewers: + domenic@chromium.org
On 2017/03/15 at 20:38:34, qyearsley wrote: > I am 95% sure the underlying bug here is https://bugs.chromium.org/p/chromium/issues/detail?id=501866; not sure if that should impact the expectations.
On 2017/03/15 at 21:14:01, domenic wrote: > On 2017/03/15 at 20:38:34, qyearsley wrote: > > > > I am 95% sure the underlying bug here is https://bugs.chromium.org/p/chromium/issues/detail?id=501866; not sure if that should impact the expectations. Awesome, thanks for noting that. I think we still want to add an expectation anyway for now (in order to keep the builder green), but whenever crbug.com/501866 is fixed we probably want to try to remove the leak expectation at the same time.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
OK to commit?
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tkent@chromium.org changed reviewers: + tkent@chromium.org
lgtm
lgtm
The CQ bit was unchecked by qyearsley@chromium.org
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489618779506300,
"parent_rev": "cdedb4788d9ead1bdb685cfa1e765ae15fcd7ea9", "commit_rev":
"3a8dda52afa9518898222bf0781add1243e2a33e"}
Message was sent while issue was closed.
Description was changed from ========== Add leak expectation for external/wpt/.../window-synthetic-errorevent.html. BUG=701695 ========== to ========== Add leak expectation for external/wpt/.../window-synthetic-errorevent.html. BUG=701695 Review-Url: https://codereview.chromium.org/2749413002 Cr-Commit-Position: refs/heads/master@{#457256} Committed: https://chromium.googlesource.com/chromium/src/+/3a8dda52afa9518898222bf0781a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3a8dda52afa9518898222bf0781a... |
