DevTools: greyed-out console suggestion should not clash with console history

DevTools: greyed-out console suggestion should not clash with console history

This patch makes greyed-out console suggestion darker. It also stops
forcing console history icon to be white in case of dimmed suggestion.

BUG=700570
R=dgozman

Review-Url: https://codereview.chromium.org/2749363002
Cr-Commit-Position: refs/heads/master@{#457477}
Committed: https://chromium.googlesource.com/chromium/src/+/d2c7002cfba5c39f3024ae5db8b7b79385726f67

[lushnikov, 2017-03-15 19:28:50]

please, take a look

[dgozman, 2017-03-15 21:17:43]

lgtm

https://codereview.chromium.org/2749363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js (right):

https://codereview.chromium.org/2749363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js:267: if
(fromElement || this._userInteracted || !this._defaultSelectionIsDimmed)
Why check for |fromElement|?

[lushnikov, 2017-03-16 08:25:46]

https://codereview.chromium.org/2749363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js (right):

https://codereview.chromium.org/2749363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js:267: if
(fromElement || this._userInteracted || !this._defaultSelectionIsDimmed)
On 2017/03/15 21:17:43, dgozman wrote:
> Why check for |fromElement|?

In this case the _userInteracted is not yet updated

[lushnikov, 2017-03-16 08:25:51]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 08:26:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 09:41:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 09:41:50]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-03-16 17:27:11]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:27:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:37:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489685231563830, "parent_rev":
"b17a05b5025de0288c1ee255ee4adceee55bf50a", "commit_rev":
"d2c7002cfba5c39f3024ae5db8b7b79385726f67"}

[commit-bot: I haz the power, 2017-03-16 17:38:24]

Description was changed from

==========
DevTools: greyed-out console suggestion should not clash with console history

This patch makes greyed-out console suggestion darker. It also stops
forcing console history icon to be white in case of dimmed suggestion.

BUG=700570
R=dgozman
==========

to

==========
DevTools: greyed-out console suggestion should not clash with console history

This patch makes greyed-out console suggestion darker. It also stops
forcing console history icon to be white in case of dimmed suggestion.

BUG=700570
R=dgozman

Review-Url: https://codereview.chromium.org/2749363002
Cr-Commit-Position: refs/heads/master@{#457477}
Committed:
https://chromium.googlesource.com/chromium/src/+/d2c7002cfba5c39f3024ae5db8b7...
==========

[commit-bot: I haz the power, 2017-03-16 17:38:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2c7002cfba5c39f3024ae5db8b7...