Add assist to convert child: to children: in Flutter new-exprs

Add assist to convert child: to children: in Flutter new-exprs

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/9a9074bf6b26d6a4202571172270c64ade4b6dc9

[messick, 2017-03-15 21:29:39]

messick@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[messick, 2017-03-15 21:29:39]

A matching quick-fix will be added shortly.

[Brian Wilkerson, 2017-03-15 21:54:23]

> A matching quick-fix will be added shortly.

Will this always be an error? Just seems odd that we'd want both a quick fix and
an assist.

Other than that, and the one comment, lgtm.

https://codereview.chromium.org/2749283004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2749283004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:520:
InstanceCreationExpression newExpr = namedExp.parent?.parent;
The parent might not be an InstanceCreationExpression. It could, for example, be
an annotation.

[messick, 2017-03-15 22:18:41]

On 2017/03/15 21:54:23, Brian Wilkerson wrote:
> > A matching quick-fix will be added shortly.
> 
> Will this always be an error? Just seems odd that we'd want both a quick fix
and
> an assist.

We've gotten multiple requests for help converting Flutter widgets to other
types of widgets. Some have a child: parameter, others have children:. There's
no predicting whether the programmer will change the name of the class first or
the name of the parameter, but unless we create a refactoring to do it all at
once there will be an error introduced somewhere.

An oddity of IJ is that if you use the re-parent widget assist then change the
class name to something that requires children:, there will be no error reported
before you have the chance to change child: to children:. I think that's due to
linked editing disabling updates until it is finished.

> Other than that, and the one comment, lgtm.
> 
>
https://codereview.chromium.org/2749283004/diff/1/pkg/analysis_server/lib/src...
> File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
> (right):
> 
>
https://codereview.chromium.org/2749283004/diff/1/pkg/analysis_server/lib/src...
> pkg/analysis_server/lib/src/services/correction/assist_internal.dart:520:
> InstanceCreationExpression newExpr = namedExp.parent?.parent;
> The parent might not be an InstanceCreationExpression. It could, for example,
be
> an annotation.

Thanks for catching that. I only want this to be active for "child:" arguments
of instance creation expressions. Is it safe to return if the parent is not an
instance creation expression? For example, could an annotation be the parent of
the named expression and have as its parent an instance creation expression?

[scheglov, 2017-03-15 23:19:03]

lgtm

https://codereview.chromium.org/2749283004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/assist_test.dart (right):

https://codereview.chromium.org/2749283004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/assist_test.dart:1047: // start
I think _setCaretLocation() does not use //start and // end comments.

[messick, 2017-03-15 23:55:13]

PTAL

I added a check for instance creation exprs before assuming it had one. If that
is too restrictive I'll loosen it.

Thanks for the reviews so far!

[Brian Wilkerson, 2017-03-16 13:52:01]

lgtm

[messick, 2017-03-16 14:44:08]

Description was changed from

==========
Add assist to convert child: to children: in Flutter new-exprs
==========

to

==========
Add assist to convert child: to children: in Flutter new-exprs

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9a9074bf6b26d6a4202571172270c64ade4b6dc9
==========

[messick, 2017-03-16 14:44:09]

Committed patchset #2 (id:20001) manually as
9a9074bf6b26d6a4202571172270c64ade4b6dc9 (presubmit successful).