arc: enable Android tracing from chrome://tracing in dev mode

arc: enable Android tracing from chrome://tracing in dev mode

To enable tracing from chrome://tracing, we create a Mojo interface
for host side to trigger tracing in Android.

The trace is written into debugfs/tracefs in dev-mode, and is read back
by debugd.

Related changes:
- http://crrev.com/2749283003
- http://ag/1915548

BUG=653795
TEST=Run chrome://tracing and see events from Android.

Review-Url: https://codereview.chromium.org/2749283003
Cr-Commit-Position: refs/heads/master@{#457368}
Committed: https://chromium.googlesource.com/chromium/src/+/da5f02c7b36a38453775a3b611f7c2f35934ce67

[shunhsingou, 2017-03-15 14:02:40]

Description was changed from

==========
arc: enable Android tracing from chrome://tracing in dev mode

To enable tracing from chrome://tracing, we create a Mojo interface
for host side to trigger tracing in Android.

The trace is written into debugfs/tracefs in dev-mode, and is read back
by debugd.

Related changes:
- http://crrev.com/2699833003
- http://ag/1915548

BUG=653795
TEST=Run chrome://tracing and see events from Android.
==========

to

==========
arc: enable Android tracing from chrome://tracing in dev mode

To enable tracing from chrome://tracing, we create a Mojo interface
for host side to trigger tracing in Android.

The trace is written into debugfs/tracefs in dev-mode, and is read back
by debugd.

Related changes:
- http://crrev.com/2749283003
- http://ag/1915548

BUG=653795
TEST=Run chrome://tracing and see events from Android.
==========

[shunhsingou, 2017-03-15 14:03:11]

The CQ bit was checked by shunhsingou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 14:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shunhsingou, 2017-03-15 14:13:55]

shunhsingou@chromium.org changed reviewers:
+ alexmos@chromium.org, dcheng@chromium.org, derat@chromium.org,
dsinclair@chromium.org, lhchavez@chromium.org, oysteine@chromium.org

[shunhsingou, 2017-03-15 14:13:56]

A fix for testing error in http://crrev.com/2699833003 #80 (The original CL got
reverted.)

I guess I need to get lgtm again here?

[Daniel Erat, 2017-03-15 14:45:27]

lgtm

the CONTENT_EXPORT in arc_tracing_agent.h is the only change, right?

[commit-bot: I haz the power, 2017-03-15 15:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 15:31:14]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2017-03-15 15:32:19]

On 2017/03/15 14:13:56, shunhsingou wrote:
> A fix for testing error in http://crrev.com/2699833003 #80 (The original CL
got
> reverted.)
> 
> I guess I need to get lgtm again here?

yes. in the future please upload the original CL as-is as Patch Set 1, and then
fix the underlying issue in Patch Set 2 to make it easier to review.

[Luis Héctor Chávez, 2017-03-15 15:38:35]

lgtm after manual inspection of the .diff files and confirming that the
inclusion of "content/common/content_export.h" and the addition of
CONTENT_EXPORT in content/browser/tracing/arc_tracing_agent.h are the only
changes.

[oystein (OOO til 10th of July), 2017-03-15 17:17:25]

lgtm

[Earl Ou, 2017-03-16 02:21:35]

The CQ bit was checked by shunhsingou@google.com

[commit-bot: I haz the power, 2017-03-16 02:21:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 02:31:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2017-03-16 02:59:14]

rs lgtm since this is a reland that changed some export things around

[alexmos, 2017-03-16 04:29:42]

LGTM

[shunhsingou, 2017-03-16 07:40:13]

The CQ bit was checked by shunhsingou@chromium.org

[commit-bot: I haz the power, 2017-03-16 07:40:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 07:44:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489650013597780, "parent_rev":
"e3ae803e5499bf5cc3104f06152b491b59668f88", "commit_rev":
"da5f02c7b36a38453775a3b611f7c2f35934ce67"}

[commit-bot: I haz the power, 2017-03-16 07:45:30]

Description was changed from

==========
arc: enable Android tracing from chrome://tracing in dev mode

To enable tracing from chrome://tracing, we create a Mojo interface
for host side to trigger tracing in Android.

The trace is written into debugfs/tracefs in dev-mode, and is read back
by debugd.

Related changes:
- http://crrev.com/2749283003
- http://ag/1915548

BUG=653795
TEST=Run chrome://tracing and see events from Android.
==========

to

==========
arc: enable Android tracing from chrome://tracing in dev mode

To enable tracing from chrome://tracing, we create a Mojo interface
for host side to trigger tracing in Android.

The trace is written into debugfs/tracefs in dev-mode, and is read back
by debugd.

Related changes:
- http://crrev.com/2749283003
- http://ag/1915548

BUG=653795
TEST=Run chrome://tracing and see events from Android.

Review-Url: https://codereview.chromium.org/2749283003
Cr-Commit-Position: refs/heads/master@{#457368}
Committed:
https://chromium.googlesource.com/chromium/src/+/da5f02c7b36a38453775a3b611f7...
==========

[commit-bot: I haz the power, 2017-03-16 07:45:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da5f02c7b36a38453775a3b611f7...