components/image_fetcher: Add a from_http_cache flag to RequestMetadata

components/image_fetcher: Add a from_http_cache flag to RequestMetadata

To be used by clients (components/doodle in particular) for metrics purposes.

This also includes a bunch of semi-related cleanups to RequestMetadata:
- Give it a ctor (because I dislike uninitialized values).
- Move RESPONSE_CODE_INVALID in there (from ImageDataFetcher).
- Rename response_code to http_response_code.

BUG=690467
Review-Url: https://codereview.chromium.org/2749283002
Cr-Commit-Position: refs/heads/master@{#457080}
Committed: https://chromium.googlesource.com/chromium/src/+/f235d928f6d89dd7decb34082353a0bde50c6597

[Marc Treib, 2017-03-15 13:10:17]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 13:10:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-03-15 13:11:16]

Description was changed from

==========
components/image_fetcher: Add a from_http_cache flag to RequestMetadata

To be used by clients (components/doodle in particular) for metrics purposes.

This also includes a bunch of semi-related cleanups:
- Give RequestMetadata a ctor (because I dislike uninitialized values)
- Move RESPONSE_CODE_INVALID into RequestMetadata

BUG=690467
==========

to

==========
components/image_fetcher: Add a from_http_cache flag to RequestMetadata

To be used by clients (components/doodle in particular) for metrics purposes.

This also includes a bunch of semi-related cleanups to RequestMetadata:
- Give it a ctor (because I dislike uninitialized values).
- Move RESPONSE_CODE_INVALID in there (from ImageDataFetcher).
- Rename response_code to http_response_code.

BUG=690467
==========

[commit-bot: I haz the power, 2017-03-15 14:16:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 14:16:47]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-03-15 14:18:09]

treib@chromium.org changed reviewers:
+ gambard@chromium.org

[Marc Treib, 2017-03-15 14:18:09]

PTAL, since you worked on this before :)

[gambard, 2017-03-15 14:29:48]

lgtm but I am not owner of favicon/ios

[Marc Treib, 2017-03-15 14:34:49]

On 2017/03/15 14:29:48, gambard wrote:
> lgtm but I am not owner of favicon/ios

Thanks!
Since that's a purely mechanical change, I was planning to just TBR it :)

[Marc Treib, 2017-03-15 14:39:54]

On 2017/03/15 14:34:49, Marc Treib wrote:
> On 2017/03/15 14:29:48, gambard wrote:
> > lgtm but I am not owner of favicon/ios
> 
> Thanks!
> Since that's a purely mechanical change, I was planning to just TBR it :)

...on second thought, let's just get it reviewed properly.

[Marc Treib, 2017-03-15 14:40:28]

treib@chromium.org changed reviewers:
+ sdefresne@chromium.org

[Marc Treib, 2017-03-15 14:40:29]

+sdefresne: Please look at components/favicon/ios/web_favicon_driver.mm.
Thanks!

[sdefresne, 2017-03-15 14:54:48]

lgtm

[Marc Treib, 2017-03-15 14:57:47]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-03-15 14:58:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 15:01:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489589867170620,
"parent_rev": "786f5cde9ec32c296aa372006df3fa3e07dd03be", "commit_rev":
"f235d928f6d89dd7decb34082353a0bde50c6597"}

[commit-bot: I haz the power, 2017-03-15 15:03:01]

Description was changed from

==========
components/image_fetcher: Add a from_http_cache flag to RequestMetadata

To be used by clients (components/doodle in particular) for metrics purposes.

This also includes a bunch of semi-related cleanups to RequestMetadata:
- Give it a ctor (because I dislike uninitialized values).
- Move RESPONSE_CODE_INVALID in there (from ImageDataFetcher).
- Rename response_code to http_response_code.

BUG=690467
==========

to

==========
components/image_fetcher: Add a from_http_cache flag to RequestMetadata

To be used by clients (components/doodle in particular) for metrics purposes.

This also includes a bunch of semi-related cleanups to RequestMetadata:
- Give it a ctor (because I dislike uninitialized values).
- Move RESPONSE_CODE_INVALID in there (from ImageDataFetcher).
- Rename response_code to http_response_code.

BUG=690467

Review-Url: https://codereview.chromium.org/2749283002
Cr-Commit-Position: refs/heads/master@{#457080}
Committed:
https://chromium.googlesource.com/chromium/src/+/f235d928f6d89dd7decb34082353...
==========

[commit-bot: I haz the power, 2017-03-15 15:03:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f235d928f6d89dd7decb34082353...