Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: components/image_fetcher/request_metadata_unittest.cc

Issue 2749283002: components/image_fetcher: Add a from_http_cache flag to RequestMetadata (Closed)
Patch Set: test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/image_fetcher/request_metadata.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/image_fetcher/request_metadata_unittest.cc
diff --git a/components/image_fetcher/request_metadata_unittest.cc b/components/image_fetcher/request_metadata_unittest.cc
index ba87ba08d8f400109c3ded47e2f8cb3f14696f65..bfda964665e32834f02ee16db43c65ac435016fc 100644
--- a/components/image_fetcher/request_metadata_unittest.cc
+++ b/components/image_fetcher/request_metadata_unittest.cc
@@ -13,8 +13,10 @@ TEST(RequestMetadataTest, Equality) {
RequestMetadata lhs;
rhs.mime_type = "testMimeType";
lhs.mime_type = "testMimeType";
- rhs.response_code = 1;
- lhs.response_code = 1;
+ rhs.http_response_code = 1;
+ lhs.http_response_code = 1;
+ rhs.from_http_cache = true;
+ lhs.from_http_cache = true;
EXPECT_EQ(rhs, lhs);
}
@@ -24,16 +26,22 @@ TEST(RequestMetadataTest, NoEquality) {
RequestMetadata lhs;
rhs.mime_type = "testMimeType";
lhs.mime_type = "testMimeType";
- rhs.response_code = 1;
- lhs.response_code = 1;
+ rhs.http_response_code = 1;
+ lhs.http_response_code = 1;
+ rhs.from_http_cache = true;
+ lhs.from_http_cache = true;
lhs.mime_type = "testOtherMimeType";
EXPECT_NE(rhs, lhs);
lhs.mime_type = "testMimeType";
- lhs.response_code = 2;
+ lhs.http_response_code = 2;
EXPECT_NE(rhs, lhs);
- lhs.response_code = 1;
+ lhs.http_response_code = 1;
+
+ lhs.from_http_cache = false;
+ EXPECT_NE(rhs, lhs);
+ lhs.from_http_cache = true;
}
} // namespace image_fetcher
« no previous file with comments | « components/image_fetcher/request_metadata.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698