Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2749273004: Remove incorrect styleResolver() checks. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect styleResolver() checks. Whether the StyleResolver is created or not does no longer tell if we have usable invalidation sets or not. Removing SubtreeStyleChange which is presumably not necessary anymore. Add a check for not scheduling any invalidation sets if the document is already marked for full recalc. Review-Url: https://codereview.chromium.org/2749273004 Cr-Commit-Position: refs/heads/master@{#457383} Committed: https://chromium.googlesource.com/chromium/src/+/5fef4a38bd9d3121a93e206d46287794788ea05a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rune
ptal
3 years, 9 months ago (2017-03-15 22:29:17 UTC) #6
meade_UTC10
lgtm Is there a bug this was causing, or is it just an optimisation?
3 years, 9 months ago (2017-03-16 05:27:06 UTC) #7
rune
On 2017/03/16 05:27:06, Eddy (OOO until 27 Mar) wrote: > lgtm > > Is there ...
3 years, 9 months ago (2017-03-16 09:29:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749273004/1
3 years, 9 months ago (2017-03-16 09:30:02 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 09:34:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fef4a38bd9d3121a93e206d4628...

Powered by Google App Engine
This is Rietveld 408576698