Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2749263002: Merged: ValueSerializer: Add an explicit tag for host objects. (Closed)

Created:
3 years, 9 months ago by Jakob Kummerow
Modified:
3 years, 9 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: ValueSerializer: Add an explicit tag for host objects. Revision: 6543519977b2012b58a4ffef28b8527db404fbdb BUG=chromium:686159, chromium:700603, v8:6080 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org Review-Url: https://codereview.chromium.org/2749263002 . Cr-Commit-Position: refs/branch-heads/5.8@{#29} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/41e12ea699bfb7ab564606b8764b3dcd5d12244e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M src/value-serializer.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
3 years, 9 months ago (2017-03-15 12:11:59 UTC) #1
Michael Hablich
On 2017/03/15 12:11:59, Jakob Kummerow wrote: rubberstamp lgtm
3 years, 9 months ago (2017-03-15 12:12:35 UTC) #2
Jakob Kummerow
3 years, 9 months ago (2017-03-15 12:13:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41e12ea699bfb7ab564606b8764b3dcd5d12244e.

Powered by Google App Engine
This is Rietveld 408576698